New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible: initial support for podman #1520

Merged

masco merged 9 commits into skydive-project:master from EmilienM:issue/1517

Mar 20, 2019

Contributor

EmilienM commented Dec 11, 2018 •

edited by lebauce

Background:
libpod aka Podman is library for running OCI-based containers in Pods.
It is likely going to replace Docker in newer versions of RHEL systems,
which means Docker won't be supported in the future.

The CLI is supposed to work like it did with Docker (with some changes);
so this patch is pretty basic. It adds skydive_container_cli variable
(default to docker for backward compatibiility) and replace the
hardcoded "docker" commands by using this variable instead.

Some adjustments were made:

podman doesn't need docker socket access.
podman doesn't support --restart natively, we need a systemd service.
podman doesn't require to have docker started.

Future iterations will be made to support proper SystemD/Podman
integration like it was done in TripleO for other containers:
http://my1.fr/blog/openstack-containerization-with-podman-part-2-operations/

Closes #1517
Signed-off-by: Emilien Macchi emilien@redhat.com

skip skydive-go-fmt
skip skydive-functional-tests-backend-elasticsearch
skip skydive-functional-tests-backend-orientdb
skip skydive-scale-tests
skip skydive-cdd-overview-tests
skip skydive-unit-tests
skip skydive-compile-tests
skip skydive-k8s-tests
skip skydive-ppc64le-tests
skip skydive-functional-hw-tests

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

22 similar comments

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Member

skydive-bot commented Dec 11, 2018

Can one of the admin review this patch ?

Collaborator

safchain commented Dec 11, 2018

ok to test

Collaborator

safchain commented Dec 11, 2018

@EmilienM I just invited you, once you accepted (please do :) we will be able to trigger CI job

Member

lebauce commented Dec 11, 2018

run skydive-vagrant-tests

2 similar comments

Member

lebauce commented Dec 11, 2018

run skydive-vagrant-tests

Contributor Author

EmilienM commented Dec 11, 2018

run skydive-vagrant-tests

Member

lebauce commented Dec 12, 2018

run vagrant-tests

lebauce force-pushed the issue/1517 branch from 54f2d9f to fcffae1 Compare

January 2, 2019 22:05

Member

lebauce commented Feb 20, 2019

run skydive-vagrant-tests

lebauce force-pushed the issue/1517 branch from a4b867f to 7d0610a Compare

February 20, 2019 17:24

Member

lebauce commented Feb 20, 2019

run skydive-vagrant-tests

safchain force-pushed the issue/1517 branch from 7d0610a to 13f7ae2 Compare

March 15, 2019 08:46

Collaborator

safchain commented Mar 15, 2019

run skydive-vagrant-tests

3 similar comments

Collaborator

safchain commented Mar 15, 2019

run skydive-vagrant-tests

Collaborator

safchain commented Mar 15, 2019

run skydive-vagrant-tests

Collaborator

safchain commented Mar 15, 2019

run skydive-vagrant-tests

Collaborator

safchain commented Mar 15, 2019

rerun skydive-vagrant-tests

safchain force-pushed the issue/1517 branch from 13f7ae2 to 83a1cd4 Compare

March 15, 2019 10:50

Collaborator

safchain commented Mar 15, 2019

run skydive-vagrant-tests

1 similar comment

Collaborator

safchain commented Mar 15, 2019

run skydive-vagrant-tests

safchain force-pushed the issue/1517 branch from 83a1cd4 to b3a0f71 Compare

March 15, 2019 12:10

Collaborator

safchain commented Mar 15, 2019

run skydive-vagrant-tests

safchain force-pushed the issue/1517 branch from b3a0f71 to e275373 Compare

March 19, 2019 15:21

Collaborator

safchain commented Mar 19, 2019

run skydive-vagrant-tests

2 similar comments

Collaborator

safchain commented Mar 19, 2019

run skydive-vagrant-tests

Member

lebauce commented Mar 19, 2019

run skydive-vagrant-tests

EmilienM and others added 9 commits

March 20, 2019 08:49


          ansible: initial support for podman

9903dce

Background:
libpod aka Podman is library for running OCI-based containers in Pods.
It is likely going to replace Docker in newer versions of RHEL systems,
which means Docker won't be supported in the future.

The CLI is supposed to work like it did with Docker (with some changes);
so this patch is pretty basic. It adds skydive_container_cli variable
(default to docker for backward compatibiility) and replace the
hardcoded "docker" commands by using this variable instead.

Some adjustments were made:
- podman doesn't need docker socket access.
- podman doesn't support --restart natively, we need a systemd service.
- podman doesn't require to have docker started.

Future iterations will be made to support proper SystemD/Podman
integration like it was done in TripleO for other containers:
http://my1.fr/blog/openstack-containerization-with-podman-part-2-operations/

Closes skydive-project#1517
Signed-off-by: Emilien Macchi <emilien@redhat.com>


          tests: fix workflow and agent metadata tests for vagrant

01ea4b8


          tests: enable socketinfo in vagrant tests

4c4dd47


          workflow: fix flow matrix graph output and tests

d30389d


          client: fix topology import

6b97802


          ci: delete virbr0 interface for vagrant during cleanup

efd05d0


          ci: fix hw tests status url

efa785b


          ci: deploy virtualbox on slaves

2af7258


          ci: deploy Docker CE

ce682bb

safchain force-pushed the issue/1517 branch from 5f8f79e to ce682bb Compare

March 20, 2019 07:53

masco merged commit d000b7b into skydive-project:master

EmilienM deleted the issue/1517 branch

October 6, 2020 13:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment