Add NSM topology probe #1636

matrohon · 2019-01-30T13:22:53Z

This patch contains the probe used for NSM demos.
Rendering patches, related to javascript files, will be part of subsequent patches.

topology/probes/nsm/nsm.go

lebauce · 2019-01-30T13:44:56Z

topology/probes/nsm/nsm.go

+
+// Stop ....
+func (p *Probe) Stop() {
+	atomic.CompareAndSwapInt64(&p.state, common.RunningState, common.StoppingState)


You should test the return value of CompareAndSwapInt64:

if !atomic.CompareAndSwapInt64(&p.state, common.RunningState, common.StoppingState) { return }

What is going to happen the swap fails? subsequent Stop are sent by the analyzer?

No. But this means the probe was not started.

lebauce · 2019-01-30T13:46:50Z

topology/probes/nsm/nsm.go

+			go p.monitorCrossConnects(mgr.Status.URL)
+		}
+	}
+	for atomic.LoadInt64(&p.state) == common.RunningState {


This waiting loop doesn't seem to be useful. Why not simply let the function exit ? (I don't think you need to execute run in a goroutine)

you're right, let's remove run() and move this code to Start()

topology/probes/nsm/connection.go

topology/probes/nsm/nsm.go

matrohon

Thanks for the review @lebauce, i've addressed your comments in 4f3dea2

matrohon · 2019-01-31T09:18:41Z

topology/probes/nsm/nsm.go

+
+// Stop ....
+func (p *Probe) Stop() {
+	atomic.CompareAndSwapInt64(&p.state, common.RunningState, common.StoppingState)


What is going to happen the swap fails? subsequent Stop are sent by the analyzer?

matrohon · 2019-01-31T09:26:28Z

topology/probes/nsm/nsm.go

+			go p.monitorCrossConnects(mgr.Status.URL)
+		}
+	}
+	for atomic.LoadInt64(&p.state) == common.RunningState {


you're right, let's remove run() and move this code to Start()

topology/probes/nsm/nsm.go

lebauce · 2019-01-31T14:08:10Z

topology/probes/nsm/nsm.go

+}
+
+// OnNodeAdded event
+// We assume skydive has locked the graph before calling this function


nit: correct, therefor this comment can safely be removed :-)

fine, that was just a reminder :)

topology/probes/nsm/nsm.go

lebauce · 2019-02-06T09:59:07Z

run skydive-functional-tests-backend-orientdb

matrohon · 2019-02-27T21:42:49Z

run skydive-functional-tests-backend-orientdb

hunchback · 2019-03-01T06:50:31Z

You should add skydive CI tests to maintain probe quality if not handled in this PR then open an issue to track.

This would include:

adding a new job skydive-nsm-tests in scripts/ci/jobs
adding a script to setup nsm on a ci host: scripts/ci/install-nsm.sh
adding a script to run nsm tests: scripts/ci/run-nsm-tests.sh
add nsm integration tests: tests/nsm_tests.go

hunchback · 2019-03-01T07:10:29Z

Regarding comments please see: https://blog.golang.org/godoc-documenting-go-code

Specifically the convention is to proceed the comment text with the name of function/method being documented.

hunchback · 2019-03-01T07:15:24Z

Other than nsm.NewNsmProve() used by the analyzer ( https://github.com/skydive-project/skydive/pull/1636/files#diff-a990c838e9c8856f44e8e5edebf41b96 ) all other function/types should be private and start with a lowercase

matrohon · 2019-03-28T14:32:57Z

@hunchback thanks for your review. I've updated and rebased the Patch.

topology/probes/nsm/connection.go

safchain · 2019-05-03T12:43:33Z

topology/probes/nsm/nsm.go

+		return
+	}
+	p.g.RemoveEventListener(p)
+	for _, conn := range p.nsmds {


p.nsmds should be protected by a mutex as it is read/write from two go-routine L104, L124 and here

I'll use the mutex of the probe struct

topology/probes/nsm/nsm.go

safchain · 2019-05-09T08:33:19Z

run skydive-scale-tests

This probe listens at NSM crossconnect monitoring events. For each new crossconnect reported by nsm, a new Skydive edge is created. See: https://github.com/networkservicemesh/networkservicemesh Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

lebauce reviewed Jan 30, 2019

View reviewed changes

matrohon force-pushed the nsm-probe-only branch 3 times, most recently from 481fbed to 4f3dea2 Compare January 31, 2019 10:17

matrohon commented Jan 31, 2019

View reviewed changes

lebauce reviewed Jan 31, 2019

View reviewed changes

matrohon force-pushed the nsm-probe-only branch 2 times, most recently from a121158 to de1d1f9 Compare February 26, 2019 14:14

matrohon force-pushed the nsm-probe-only branch from de1d1f9 to 52d2bf2 Compare March 28, 2019 14:31

matrohon force-pushed the nsm-probe-only branch from 52d2bf2 to 6a2f45d Compare March 29, 2019 15:57

matrohon force-pushed the nsm-probe-only branch from 4650437 to d1be563 Compare April 30, 2019 09:11

safchain reviewed May 3, 2019

View reviewed changes

topology/probes/nsm/nsm.go Outdated Show resolved Hide resolved

lebauce reviewed May 6, 2019

View reviewed changes

topology/probes/nsm/nsm.go Outdated Show resolved Hide resolved

matrohon force-pushed the nsm-probe-only branch from 9ac130a to af8e41c Compare May 8, 2019 12:14

matrohon force-pushed the nsm-probe-only branch 4 times, most recently from 77a2a70 to 56496d1 Compare May 15, 2019 08:30

matrohon added 4 commits May 17, 2019 09:48

Add NSM probe

47ce06f

This probe listens at NSM crossconnect monitoring events. For each new crossconnect reported by nsm, a new Skydive edge is created. See: https://github.com/networkservicemesh/networkservicemesh Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

fix nits

3b7bbed

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

mv import from ligato to networkservicemesh

659076f

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

update version of networkservicemesh libraries

f26712f

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

matrohon added 20 commits May 17, 2019 09:48

use getter to access context ips

9a235fe

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

fix UT failures

d982150

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

disable the probe for Windows

623b5bb

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Update Apache 2 licence

6708a77

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Fix following @lebauce review

8f8668d

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Remove unused libraries

84ab748

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Fix error msg and comments

bce2cc0

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Add NSM panels

31ee5f3

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Bump NSM version

a385e92

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Update functions naming for convention

2693a26

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Fix linter warning

c45ca47

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

fix error during rebase

32275ec

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Use k8s cache informer instead of polling

6a2652a

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

fix lint error

355f4b4

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Remove unused list of nsm managers

a743a42

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

protect nsmds and add logs

8453137

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Fix UT error

e95215f

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Ignore UPDATE/DOWN messages

2aca733

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Stop relying on crossconnect Id only

9321f5d

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

Fix Highlight issues

864bb4d

Signed-off-by: Mathieu Rohon <mathieu.rohon@orange.com>

matrohon force-pushed the nsm-probe-only branch from ae0e1d6 to 864bb4d Compare May 17, 2019 10:13

lebauce merged commit d7997fc into skydive-project:master May 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add NSM topology probe #1636

Add NSM topology probe #1636

matrohon commented Jan 30, 2019

lebauce Jan 30, 2019

matrohon Jan 31, 2019

lebauce Jan 31, 2019

lebauce Jan 30, 2019

matrohon Jan 31, 2019

matrohon left a comment

matrohon Jan 31, 2019

matrohon Jan 31, 2019

lebauce Jan 31, 2019

matrohon Jan 31, 2019

lebauce commented Feb 6, 2019

matrohon commented Feb 27, 2019

hunchback commented Mar 1, 2019 •

edited

Loading

hunchback commented Mar 1, 2019

hunchback commented Mar 1, 2019

matrohon commented Mar 28, 2019

safchain May 3, 2019

matrohon May 6, 2019

safchain commented May 9, 2019

Add NSM topology probe #1636

Add NSM topology probe #1636

Conversation

matrohon commented Jan 30, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matrohon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lebauce commented Feb 6, 2019

matrohon commented Feb 27, 2019

hunchback commented Mar 1, 2019 • edited Loading

hunchback commented Mar 1, 2019

hunchback commented Mar 1, 2019

matrohon commented Mar 28, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

safchain commented May 9, 2019

hunchback commented Mar 1, 2019 •

edited

Loading