New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce flow/packet target, local and netflow targets #1843
Conversation
|
other that being able to report NetFlowV5 from agent, you also may want to use NetFlowV5 as an alternative for reporting flows from the agents to analyzer, by that also solving limited network bw (by implementing sampling capabilities of NetFlowV5). |
|
@hunchback from my point of view, expire/update of flow is already a sampling mechanism. |
|
@hunchback Quoted from https://stackoverflow.com/questions/41087206/on-github-whats-the-difference-between-reviewer-and-assignee :
|
42ad9e6
to
2ecf324
Compare
138f6d0
to
e3d8e73
Compare
|
run skydive-functional-tests-backend-orientdb |
|
run skydive-functional-tests-backend-elasticsearch |
common/netns.go
Outdated
| @@ -79,3 +79,23 @@ func NewNetNsContext(path string) (*NetNSContext, error) { | |||
| newns: newns, | |||
| }, nil | |||
| } | |||
|
|
|||
| // ExecInNs call the given function in the context of the given netns | |||
| func ExecInNs(nsPath string, fnc func(origns, newns netns.NsHandle) error) error { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we don't actually jump into the namespace. So ExecInNs is a bit misleading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed and not used anymore, going to revert this
|
|
||
| // NewERSpanTarget returns a new ERSpan target | ||
| func NewERSpanTarget(g *graph.Graph, n *graph.Node, capture *types.Capture, nodeTID string) (*ERSpanTarget, error) { | ||
| fd := C.open_raw_socket(C.uint16_t(syscall.IPPROTO_GRE)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using common.RawSocket ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with common.RawSocket we can't specify the protocol properly, we can specify the ethertype not the IP protocol
|
run skydive-scale-tests |
No description provided.