Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce flow/packet target, local and netflow targets #1843

Merged
merged 9 commits into from Jun 14, 2019

Conversation

safchain
Copy link
Collaborator

No description provided.

@hunchback
Copy link
Collaborator

other that being able to report NetFlowV5 from agent, you also may want to use NetFlowV5 as an alternative for reporting flows from the agents to analyzer, by that also solving limited network bw (by implementing sampling capabilities of NetFlowV5).

@safchain
Copy link
Collaborator Author

safchain commented Jun 1, 2019

@hunchback from my point of view, expire/update of flow is already a sampling mechanism.

@hunchback hunchback self-assigned this Jun 1, 2019
@lebauce
Copy link
Member

lebauce commented Jun 4, 2019

@hunchback Quoted from https://stackoverflow.com/questions/41087206/on-github-whats-the-difference-between-reviewer-and-assignee :

According to official github documentation, Assignee is a person who is working on specific issues and pull requests. It is sometimes confused as a reviewer. It is actually meant to be used with issues rather than pull request so that when we receive a issue we can assign someone to fix it.

@hunchback hunchback removed their assignment Jun 4, 2019
@safchain safchain force-pushed the flow-stream branch 6 times, most recently from 42ad9e6 to 2ecf324 Compare June 5, 2019 17:35
@safchain safchain marked this pull request as ready for review June 5, 2019 19:24
@safchain safchain force-pushed the flow-stream branch 3 times, most recently from 138f6d0 to e3d8e73 Compare June 10, 2019 14:37
common/types.go Outdated Show resolved Hide resolved
@safchain
Copy link
Collaborator Author

run skydive-functional-tests-backend-orientdb

@safchain
Copy link
Collaborator Author

run skydive-functional-tests-backend-elasticsearch

common/netns.go Outdated
@@ -79,3 +79,23 @@ func NewNetNsContext(path string) (*NetNSContext, error) {
newns: newns,
}, nil
}

// ExecInNs call the given function in the context of the given netns
func ExecInNs(nsPath string, fnc func(origns, newns netns.NsHandle) error) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we don't actually jump into the namespace. So ExecInNs is a bit misleading

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed and not used anymore, going to revert this


// NewERSpanTarget returns a new ERSpan target
func NewERSpanTarget(g *graph.Graph, n *graph.Node, capture *types.Capture, nodeTID string) (*ERSpanTarget, error) {
fd := C.open_raw_socket(C.uint16_t(syscall.IPPROTO_GRE))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using common.RawSocket ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with common.RawSocket we can't specify the protocol properly, we can specify the ethertype not the IP protocol

flow/client/flow_client.go Outdated Show resolved Hide resolved
@safchain
Copy link
Collaborator Author

run skydive-scale-tests
run skydive-cdd-overview-tests

@lebauce lebauce merged commit 322ca80 into skydive-project:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants