Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Java IconSpinnerItem can be created just with 9 parameters #48

Closed
waver11 opened this issue Dec 8, 2020 · 4 comments
Closed

In Java IconSpinnerItem can be created just with 9 parameters #48

waver11 opened this issue Dec 8, 2020 · 4 comments
Assignees
Labels
released released already the last version

Comments

@waver11
Copy link

waver11 commented Dec 8, 2020

In version 1.1.6 IconSpinnerItem can be created just with 9 parameters.

ArrayList<IconSpinnerItem> iconSpinnerItems = new ArrayList<>();
        iconSpinnerItems.add(new IconSpinnerItem("Spain", ContextCompat.getDrawable(getActivity(), R.drawable.spain),null,null,0,null,null,null,null));
        iconSpinnerItems.add(new IconSpinnerItem("US", ContextCompat.getDrawable(getActivity(), R.drawable.unitedstates),null,null,0,null,null,null,null));
        iconSpinnerItems.add(new IconSpinnerItem("UK", ContextCompat.getDrawable(getActivity(), R.drawable.spain),null,null,0,null,null,null,null));

In this implementation Icons are not visible in dropdown!
What should be passed as arguments to constructor so icon will be visible in dropdown?
Thanks for help

@skydoves
Copy link
Owner

skydoves commented Dec 8, 2020

Hi, I just build the demo project with Java code but it works fine for me.
And you don't need to pass all parameters to the IconSpinnerItem .

 new IconSpinnerItem("Canada", ContextCompat.getDrawable(context, R.drawable.canada));

Furthermore, you should check the adapter is the IconSpinnerAdapter.

@waver11
Copy link
Author

waver11 commented Dec 8, 2020

please check latest version com.github.skydoves:powerspinner:1.1.6

I found out that everything works as expected in version 1.1.5

@skydoves
Copy link
Owner

skydoves commented Dec 9, 2020

Hmm, I think there was some shipping error when publishing.
I will check it soon!

@skydoves
Copy link
Owner

skydoves commented Dec 9, 2020

@waver11
Just published a new version 1.1.7!
Thanks for your issue :)

@skydoves skydoves added the released released already the last version label Dec 9, 2020
@skydoves skydoves self-assigned this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released released already the last version
Projects
None yet
Development

No branches or pull requests

2 participants