Fix duplicate 'now' declarations breaking dashboard JS#134
Merged
Conversation
initializeDashboard() declared `const now` and `const currentHour` twice
in the same scope (lines 1658 and 1672). Modern browsers reject this
with a parse-time SyntaxError ("Identifier 'now' has already been
declared"), which silently kills the entire <script> block — no
event handlers get attached, no buttons work, and no /api/* calls
are ever made even though the dashboard renders.
Rename the second pair to `currentHourInt` (and `tickHour` inside the
setInterval callback) so the two distinct uses don't collide.
This was referenced May 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initializeDashboard()declaredconst nowandconst currentHourtwice in the same scope (lines 1658 and 1672). Modern browsers reject this with a parse-timeSyntaxError: Identifier 'now' has already been declared, which silently kills the entire<script>block — no event handlers get attached, no buttons work, and no/api/*calls are ever made even thoughdashboard.htmlrenders.The two uses had different semantics (fractional hour for
grayLineSlider, integer hour forgrayLineTimeSlider), so I renamed the second pair tocurrentHourIntandtickHourrather than dedupe.Repro
pip install -e ".[dashboard]"and rundvoacap-dashboard.http://localhost:8000in any modern browser.SyntaxErrorplus a cascade oftriggerRefresh is not defined,showSettings is not defined,showTab is not definedReferenceErrors./api/...request.Test plan
POST /api/generate.https://claude.ai/code/session_01PLeFRjjJUKnUAjA5imhsZz
Generated by Claude Code