fix: prevent stack overflow in type inference if update tree is too deep

skylot · May 15, 2019 · 0ca2789 · 0ca2789
1 parent 119709b
commit 0ca2789
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/jadx-core/src/main/java/jadx/core/dex/visitors/typeinference/TypeUpdate.java b/jadx-core/src/main/java/jadx/core/dex/visitors/typeinference/TypeUpdate.java
@@ -151,6 +151,12 @@ private TypeUpdateResult requestUpdate(TypeUpdateInfo updateInfo, InsnArg arg, A
 			return CHANGED;
 		}
 		updateInfo.requestUpdate(arg, candidateType);
+		if (updateInfo.getUpdates().size() > 500) {
+			if (Consts.DEBUG) {
+				LOG.error("Type update error: too deep update tree");
+			}
+			return REJECT;
+		}
 		try {
 			TypeUpdateResult result = runListeners(updateInfo, arg, candidateType);
 			if (result == REJECT) {