Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gui): save the class tree width and restore it upon jadx-gui start #606

Merged
merged 4 commits into from May 6, 2019

Conversation

@jpstotz
Copy link
Collaborator

jpstotz commented Apr 17, 2019

No description provided.

@jpstotz

This comment has been minimized.

Copy link
Collaborator Author

jpstotz commented Apr 17, 2019

At a first glance #605 does more or less the same (saw #605 right after I created this PR) . The only difference is that this PR saves the tree width not project based.
For cases where a new APK file is loaded and therefore no project file is available #605 is not effective, in such a case this PR would help. Therefore I think both PRs have their justifications.

@asashour

This comment has been minimized.

Copy link
Contributor

asashour commented Apr 18, 2019

This proves there is a need for this feature :)

I guess since the tree width is more related to the window size, I am now inclined to have it as a global setting, not a project-specific.

@skylot

This comment has been minimized.

Copy link
Owner

skylot commented Apr 18, 2019

I agree, tree size is better to store in global settings.
@jpstotz for save/change tree size please use methods in JSplitPane component instead changing size of it children. Also you need to use some kind of listener to save size on changes.

@asashour

This comment has been minimized.

Copy link
Contributor

asashour commented Apr 18, 2019

Great, I will remove the width from the other PR then

@asashour

This comment has been minimized.

Copy link
Contributor

asashour commented Apr 24, 2019

Also you need to use some kind of listener to save size on changes.

I guess no need for a listener, since we also save the window size only in closeWindow()

@skylot

This comment has been minimized.

Copy link
Owner

skylot commented May 6, 2019

@jpstotz will you finish this PR according to suggestions about using JSplitPane to change split size?

@jpstotz

This comment has been minimized.

Copy link
Collaborator Author

jpstotz commented May 6, 2019

@skylot Sorry I did not realize that this PR is still open. I changed the code to use JSplitPane. I also added some minimum size restrictions to make sure users can't bring jadx into a state where important components are not visible.

@skylot skylot merged commit 65818dc into skylot:master May 6, 2019
5 checks passed
5 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (skylot) No manifest changes detected
security/snyk - jadx-cli/build.gradle (skylot) No manifest changes detected
security/snyk - jadx-core/build.gradle (skylot) No manifest changes detected
security/snyk - jadx-gui/build.gradle (skylot) No manifest changes detected
@skylot

This comment has been minimized.

Copy link
Owner

skylot commented May 6, 2019

@jpstotz thank you!

@jpstotz jpstotz deleted the jpstotz:treeWidth branch May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.