Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include hmac in distribution? #29

Closed
toonetown opened this issue Apr 27, 2016 · 4 comments
Closed

Include hmac in distribution? #29

toonetown opened this issue Apr 27, 2016 · 4 comments

Comments

@toonetown
Copy link
Contributor

I don't know if it's possible (for licensing/other reasons), but it would be nice to include the stuff inside of "vendor/resty" in the packaged distribution when builds are made.

Again - not a super urgent issue - and it's something that can be grabbed separately, but it's kind of nice to have a distribution package that contains all the required files.

@SkyLothar
Copy link
Owner

SkyLothar commented Apr 27, 2016

I'm not super familiar with luarock, but according to this rockspec, I think I already included the hmac lib.

So, I guess you're talking about the .tar.gz and .zip package in release, right?

@toonetown
Copy link
Contributor Author

Yeah - particularly because I also do not use luarocks. 😄 I'm talking about the .tar.gz that you created in the release (https://github.com/SkyLothar/lua-resty-jwt/releases/download/v0.1.4/lua-resty-jwt-0.1.4.tar.gz)

Currently, I'm actually just grabbing the source and extracting just the lib and vendor paths...so it's working just fine for me. I just thought it might be nice (for future releases) to also include hmac.lua in that release package.

@SkyLothar
Copy link
Owner

It's a mistake.
I put hmac.lua in older releases, but I forgot to put it in 0.1.4.
Just updated the 0.1.4 release archives, hmac.lua included.

@toonetown
Copy link
Contributor Author

Cool - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants