Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.13.0 installs include/BUILD.bazel #1104

Closed
yurivict opened this issue Jan 18, 2024 · 10 comments · Fixed by #1107
Closed

3.13.0 installs include/BUILD.bazel #1104

yurivict opened this issue Jan 18, 2024 · 10 comments · Fixed by #1107
Assignees
Labels
build system requests or issues related to the build system solved available upstream or in a branch

Comments

@yurivict
Copy link

Could you please remove it?

@skypjack skypjack self-assigned this Jan 18, 2024
@skypjack skypjack added the triage pending issue, PR or whatever label Jan 18, 2024
@skypjack
Copy link
Owner

Out of curiosity, was it there in the previous version? I don't think anything has changed in the meantime but I could be wrong. 🤔

@yurivict
Copy link
Author

No, it wasn't there in 3.12.2

@skypjack
Copy link
Owner

I think this is eligible for the next patch version. Can you test a patch when it's upstream and before adding it to the new release?
Just to confirm that it works as expected. I think I can push it on Monday (mostly because I'm out until then 😅).

@skypjack skypjack added build system requests or issues related to the build system and removed triage pending issue, PR or whatever labels Jan 20, 2024
@zaucy
Copy link
Contributor

zaucy commented Jan 20, 2024

Sorry this was introduced by me during bzlmod support. I don't use cmake much these days and didn't catch it 😅

Here's a patch #1107

@skypjack
Copy link
Owner

No worries at all @zaucy and thanks for your help! 🙂

@skypjack
Copy link
Owner

Fix available on branches wip and v3.13.x (next patch release for version 3.13).
Let me know if it doesn't work for you. Thanks. 👍

@skypjack skypjack added the solved available upstream or in a branch label Jan 22, 2024
@skypjack
Copy link
Owner

skypjack commented Feb 2, 2024

Fixed with version 3.13.1, thanks for pointing this out.

@skypjack skypjack closed this as completed Feb 2, 2024
@skypjack
Copy link
Owner

@zaucy before trying to fix it on my own, I think it's worth to ping you 🙂 bazel is complaining since a while ago, see here for an example. Is it an easy fix? Any suggestions?
Thanks in advance for your help. 🙏

@zaucy
Copy link
Contributor

zaucy commented Mar 13, 2024

@skypjack done! it's here #1124

@skypjack
Copy link
Owner

Oh, wow @zaucy thank you very much!! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system requests or issues related to the build system solved available upstream or in a branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants