Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: passing an invalid image URL does not result on error feedback #8

Closed
1 task done
kyranet opened this issue May 20, 2023 · 0 comments · Fixed by #15
Closed
1 task done

bug: passing an invalid image URL does not result on error feedback #8

kyranet opened this issue May 20, 2023 · 0 comments · Fixed by #15
Labels
bug Something isn't working
Milestone
v1

Comments

@kyranet
Copy link
Member

kyranet commented May 20, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Description of the bug

If the user gives any image URL that cannot be loaded, the website shows a warning box saying that an image URL has to be given rather than being more descriptive.

Steps To Reproduce

Insert an invalid link or image link.

Expected behavior

It should display a descriptive error.

Screenshots

No response

Additional context

Comments at #34.
@kyranet kyranet added the bug Something isn't working label May 20, 2023
@kyranet kyranet added this to the v1 milestone May 20, 2023
kyranet added a commit that referenced this issue May 20, 2023
@kyranet
fix: improve image loading
2322bba 
Fixes #8
@kyranet kyranet mentioned this issue May 20, 2023
Merged
@favna favna closed this as completed in #15 May 21, 2023
favna pushed a commit that referenced this issue May 21, 2023
@kyranet
fix: improve image loading (#15)
3af5265 
Fixes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

fix: improve image loading skyra-project/memes.skyra.pw
1 participant
@kyranet