Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suggestions module #724

Closed
wants to merge 11 commits into from
Closed

Conversation

@cfanoulis
Copy link
Contributor

cfanoulis commented Jan 4, 2020

Closes #709

Note for reviewers: Please start from the point marked as // Review as I'm most worried about those

cfanoulis added 4 commits Jan 2, 2020
@Rexogamer

This comment has been minimized.

Copy link

Rexogamer commented Jan 5, 2020

question: shouldn’t you put the strings in that string file? other than that, at first I was confused why you sent the setup message twice, but it turned out to be that the first one was for when you couldn’t set up a channel

@cfanoulis

This comment has been minimized.

Copy link
Contributor Author

cfanoulis commented Jan 5, 2020

@Rexogamer I first write the code then put the strings in the file with an i18n commit

cfanoulis added 4 commits Jan 5, 2020
**NOT TESTED**
@cfanoulis cfanoulis marked this pull request as ready for review Jan 6, 2020
@cfanoulis cfanoulis requested a review from kyranet as a code owner Jan 6, 2020
@cfanoulis cfanoulis force-pushed the cfanoulis:suggestions branch from c679b8b to b9adbbb Jan 6, 2020
@Favna

This comment has been minimized.

Copy link
Member

Favna commented Jan 6, 2020

Where are the path aliases

@cfanoulis

This comment has been minimized.

Copy link
Contributor Author

cfanoulis commented Jan 6, 2020

whi - oh, right

if ('show-author' in message.flagArgs) return message.author.tag;
if ('hide-author' in message.flagArgs || HideAuthor) {
Comment on lines +105 to +106

This comment has been minimized.

Copy link
@Favna

Favna Jan 11, 2020

Member

or --showAuthor and --hideAuthor

src/languages/en-US.ts Show resolved Hide resolved
src/languages/en-US.ts Outdated Show resolved Hide resolved
Co-Authored-By: Jeroen Claassens <jeroen.claassens@live.nl>
['suggestion', 'Your well... suggestion']
],
examples: [
'let\'s ban @enkiel#8897'

This comment has been minimized.

Copy link
@Favna

Favna Jan 11, 2020

Member
Suggested change
'let\'s ban @enkiel#8897'
'let\'s ban @DiscordUser#0000'
['suggestion', 'Your well... suggestion']
],
examples: [
'let\'s ban @Barrinson#0951'

This comment has been minimized.

Copy link
@Favna

Favna Jan 11, 2020

Member
Suggested change
'let\'s ban @Barrinson#0951'
'let\'s ban @DiscordUser#0000'
@cfanoulis

This comment has been minimized.

Copy link
Contributor Author

cfanoulis commented Jan 18, 2020

closing in favour of a new PR with a less cluttered commit history

@cfanoulis cfanoulis closed this Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.