Update clone dependency to >=2.1.1 <2.2#1359
Merged
jhchen merged 1 commit intoslab:developfrom Mar 9, 2017
c-w:develop
Merged
Conversation
In version 2.1.1, CloneJS improved support for Internet Explorer. See this pull request for details: pvorb/clone#77 From my limited testing so far, the fixes in CloneJS should enable QuillJS to run on a wider variety of Windows + Internet Explorer systems. For example, I've seen the dependency update fix some crashes of QuillJS on Internet Explorer 10 running on Windows Server 2012 R2.
Contributor
Author
|
The Travis build is failing due to an authentication error with Saucelabs: Could you please advise me how to fix this error? I've seen all tests pass locally. |
Member
|
Apologies travis was not working for Pull Requests. I can merge this request but a major blocker for IE10 is because Quill uses MutationObservers. |
Contributor
Author
|
Thanks for the merge @jhchen. Would you be open to including a polyfill for MutationObserver into Quill to add support for IE9 and IE10? If so: I'd be happy to open a pull request to implement this. |
Member
|
I don't think that polyfill (or any other I'm aware of) works for contenteditable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In version 2.1.1, CloneJS improved support for Internet Explorer. See this pull request for details: pvorb/clone#77
From my limited testing so far, the fixes in CloneJS should enable QuillJS to run on a wider variety of Windows + Internet Explorer systems. For example, I've seen the dependency update fix some crashes of QuillJS on Internet Explorer 10 running on Windows Server 2012 R2.
If you're interested in merging this pull request, we should add some more Windows + Internet Explorer systems to the Saucelabs test matrix for QuillJS and see if we can increase support. Is this something that you'd be interested in doing?