Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add socket mode example link to README #1015

Merged
merged 3 commits into from Jan 14, 2022
Merged

Conversation

itayd
Copy link
Contributor

@itayd itayd commented Jan 9, 2022

As mentioned in the documentation in https://api.slack.com/rtm:
"For most applications, Socket Mode is a better way to communicate with Slack."

Personally, I got confused between RTM and Socket Mode, and I think this might help future developers.

As mentioned in the documentation in https://api.slack.com/rtm:
"For most applications, Socket Mode is a better way to communicate with Slack."

(Personally I got confused between RTM and Socket Mode, and I think this might help future developers)
@kanata2 kanata2 linked an issue Jan 9, 2022 that may be closed by this pull request
README.md Outdated
## Minimal RTM usage:

(For most applications, Socket Mode is a better way to communicate with Slack)
Copy link
Member

@kanata2 kanata2 Jan 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the official announcement.

Copy link
Contributor Author

@itayd itayd Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Note that I couldn't link to the exact note but to the page that mentioned it. It's very prominent there though.

@kanata2 kanata2 added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Jan 9, 2022
Copy link
Member

@kanata2 kanata2 left a comment

Thanks!

@kanata2 kanata2 removed the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Jan 12, 2022
@itayd
Copy link
Contributor Author

itayd commented Jan 13, 2022

Hey @kanata2 , thanks for approving! Is there anything that delays merging? Wondering if I'm missing any steps...

@kanata2
Copy link
Member

kanata2 commented Jan 14, 2022

Sorry for the delay. I'll merge this.

@kanata2 kanata2 merged commit 4ee274f into slack-go:master Jan 14, 2022
6 checks passed
@itayd itayd deleted the patch-1 branch Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to Socket Mode example in README.md
2 participants