Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Errno::ECONNRESET and empty buffer reads with celluloid-io #216

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
1 participant
@dblock
Copy link
Collaborator

dblock commented Aug 20, 2018

Was a suggested fix for #208 from faye/websocket-driver-ruby#61, but doesn't appear to have solved that problem.

@dblock dblock force-pushed the dblock:fix-208 branch 5 times, most recently from 36e23c2 to cc8eb78 Aug 20, 2018

@dblock dblock changed the title Fix #208: slack-side disconnects with celluloid-io. Proposed fix #208: slack-side disconnects with celluloid-io. Aug 20, 2018

@dblock dblock force-pushed the dblock:fix-208 branch from cc8eb78 to 63ee8db Aug 20, 2018

@dblock dblock force-pushed the dblock:fix-208 branch from 63ee8db to c7a067d Aug 20, 2018

@dblock dblock changed the title Proposed fix #208: slack-side disconnects with celluloid-io. Handle Errno::ECONNRESET and empty buffer reads with celluloid-io Aug 20, 2018

@dblock dblock merged commit 51e5522 into slack-ruby:master Aug 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dblock dblock deleted the dblock:fix-208 branch Aug 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.