Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the immediate retry to give the client time to reconnect #234

Merged
merged 2 commits into from Oct 28, 2018

Conversation

Projects
None yet
2 participants
@RodneyU215
Copy link
Collaborator

RodneyU215 commented Oct 28, 2018

Summary

  1. #run_ping! will no longer raise errors since it's no longer retrying the ping request. Instead the code will wait, until the reactor's timer, calls it again.
  2. #restart_async will now reset @last_message_at, so that when the reactor's timer calls #run_ping! again, it will not raise an exception.

Requirements

@dblock dblock merged commit e870287 into slack-ruby:master Oct 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.