Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unexpected errors in ping worker. #279

Merged
merged 1 commit into from Jul 20, 2019

Conversation

@dblock
Copy link
Collaborator

commented Jul 20, 2019

Fixes #277, #280.

@dblock dblock force-pushed the dblock:fix-277 branch 2 times, most recently from 5885323 to 992014a Jul 20, 2019

@dblock dblock changed the title Handle EOFError, Errno::ECONNRESET, Errno::EPIPE in ping worker. Handle unexpected errors in ping worker. Jul 20, 2019

@dblock dblock force-pushed the dblock:fix-277 branch from 992014a to 9934f02 Jul 20, 2019

@dblock dblock merged commit 30450bc into slack-ruby:master Jul 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dblock dblock deleted the dblock:fix-277 branch Jul 20, 2019

@ioquatix

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

It looks reasonable. If an error is not handled, the task will be terminated and the error logged.

dblock added a commit to dblock/code.dblock.org that referenced this pull request Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.