From 8467341638cbb17b142c6df172896f0e315b8143 Mon Sep 17 00:00:00 2001 From: Sarah Jiang Date: Tue, 13 Sep 2022 13:35:46 -0700 Subject: [PATCH] Fix references to getManifestData function` --- src/App-slack-function.spec.ts | 2 +- src/SlackFunction.spec.ts | 6 +++--- src/SlackFunction.ts | 4 +++- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/App-slack-function.spec.ts b/src/App-slack-function.spec.ts index 0d9feefbc..38a07aaae 100644 --- a/src/App-slack-function.spec.ts +++ b/src/App-slack-function.spec.ts @@ -93,7 +93,7 @@ function withNoopAppMetadata(): Override { export default function withMockValidManifestUtil(functionCallbackId: string): Override { const mockManifestOutput = JSON.parse(`{"functions": {"${functionCallbackId}": {}}}`); return { - './cli/hook-utils/manifest': { + './cli/hook-utils/get-manifest-data': { getManifestData: () => mockManifestOutput, }, }; diff --git a/src/SlackFunction.spec.ts b/src/SlackFunction.spec.ts index b7576aa8a..b53159f39 100644 --- a/src/SlackFunction.spec.ts +++ b/src/SlackFunction.spec.ts @@ -346,7 +346,7 @@ describe('SlackFunction utils', () => { }; const getManifestSpy = sinon.spy(() => badManifestOutput); const { findMatchingManifestDefinition } = await importSlackFunctionModule({ - './cli/hook-utils/manifest': { + './cli/hook-utils/get-manifest-data': { getManifestData: getManifestSpy, }, }); @@ -363,7 +363,7 @@ describe('SlackFunction utils', () => { }, }; const { findMatchingManifestDefinition } = await importSlackFunctionModule({ - './cli/hook-utils/manifest': { + './cli/hook-utils/get-manifest-data': { getManifestData: () => mockManifestOutput, }, }); @@ -379,7 +379,7 @@ describe('SlackFunction utils', () => { }, }; const { findMatchingManifestDefinition } = await importSlackFunctionModule({ - './cli/hook-utils/manifest': { + './cli/hook-utils/get-manifest-data': { getManifestData: () => mockManifestOutput, }, }); diff --git a/src/SlackFunction.ts b/src/SlackFunction.ts index 3bf45e701..58f5c292b 100644 --- a/src/SlackFunction.ts +++ b/src/SlackFunction.ts @@ -24,6 +24,8 @@ import { // eslint-disable-next-line export const manifestUtil = require('./cli/hook-utils/manifest'); +// eslint-disable-next-line +export const getManifestDataUtil = require('./cli/hook-utils/get-manifest-data'); /* Types */ export interface SlackFunctionExecutedMiddlewareArgs extends SlackEventMiddlewareArgs<'function_executed'> { @@ -506,7 +508,7 @@ export function hasMatchingManifestDefinition( export function findMatchingManifestDefinition(callbackId: string): ManifestDefinitionResult { const result: ManifestDefinitionResult = { matchFound: false, fnKeys: [] }; // call the hook to get the manifest - const manifest = manifestUtil.getManifestData(process.cwd()); + const manifest = getManifestDataUtil.getManifestData(process.cwd()); // manifest file must exist in the project if (!('functions' in manifest)) {