Skip to content

ci: pin actions workflow step hashes and use minimum permissions - #2537

Merged
zimeg merged 2 commits into
mainfrom
ci-audit
May 21, 2025
Merged

ci: pin actions workflow step hashes and use minimum permissions#2537
zimeg merged 2 commits into
mainfrom
ci-audit

Conversation

@zimeg

@zimeg zimeg commented May 20, 2025

Copy link
Copy Markdown
Member

Summary

This PR uses the wonderful zizmor tool to audit our own workflows and pinact for pinned versioning 👾

Reviewers

A similar audit can be performed with the zizmor tool:

$ zizmor .
...
No findings to report. Good job! (4 suppressed)

The suppressed findings are expected permission blocks at the top-level of a workflow, but we set this for each job.

Requirements

@zimeg zimeg added security dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels May 20, 2025
@codecov

codecov Bot commented May 20, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.35%. Comparing base (6c00291) to head (799a30f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2537   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files          37       37           
  Lines        7575     7575           
  Branches      664      664           
=======================================
  Hits         7072     7072           
  Misses        498      498           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WilliamBergamin WilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@WilliamBergamin WilliamBergamin modified the milestone: 4.3.1 May 20, 2025
@zimeg

zimeg commented May 21, 2025

Copy link
Copy Markdown
Member Author

@WilliamBergamin I appreciate the sharp eye in these reviews - let's merge this! 🙏 ✨

@zimeg
zimeg merged commit 0e15a81 into main May 21, 2025
@zimeg
zimeg deleted the ci-audit branch May 21, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants