fixed node-slack-sdk issue 1156, socketMode connection error not bein… #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengill
added
the
bug
Codecov Report
@@ Coverage Diff @@
## main #764 +/- ##
==========================================
+ Coverage 65.00% 65.24% +0.24%
==========================================
Files 11 11
Lines 1086 1082 -4
Branches 320 320
==========================================
Hits 706 706
+ Misses 321 317 -4
Partials 59 59
Continue to review full report at Codecov.
|
mwbrooks
approved these changes
Jan 21, 2021
Comment on lines
+151
to
+153
| public start(): Promise<void | WebAPICallResult> { | ||
| // start socket mode client | ||
| return this.client.start(); |
There was a problem hiding this comment.
Nice use of the OR instead of updating it to only WebAPICallResult.
Do we need to add any test coverage for this update?
There was a problem hiding this comment.
Do we need test coverage? Yes
Do we have tests for SocketModeReceiver yet?....no :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g surfaced
Summary
Fixes slackapi/node-slack-sdk#1156
Requirements (place an
xin each[ ])