Fix unexpected newline after super #595
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
So I know that the project has specifically pinned coffeescript 1.x in its package.json but I'm trying to use coffeescript 2.x in my project because it has other things I need (namely async/await) and the bot crashes on start, referencing this line from bot.coffee:
I supposed that this keyword has now become ambiguous without brackets/parentheses but to make sure, I dug up the breaking changes list for the coffeescript 2.0.0 release and found this:
Source: https://coffeescript.org/#breaking-changes-super-extends
After adding the brackets the coffeelint tool no longer spits out that error and when running it it "works on my machine". Tests are still passing and also I can't it imagine it having any adverse effects on users of older versions of coffeescript because the parentheses were optional so far.
Requirements