Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

Commit

Permalink
1.1.0
Browse files Browse the repository at this point in the history
  • Loading branch information
Shane DeWael committed Feb 27, 2019
1 parent af1688c commit 9cfdcba
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
10 changes: 7 additions & 3 deletions docs/reference.md
Expand Up @@ -156,7 +156,9 @@ following table describes it fully.
| --- | --- | --- |
| matchingConstraints | <code>Object</code> \| <code>string</code> \| <code>RegExp</code> | the callback ID (as a string or RegExp) or an object describing the constraints to match actions for the handler. |
| [matchingConstraints.callbackId] | <code>string</code> \| <code>RegExp</code> | a string or RegExp to match against the `callback_id` |
| [matchingConstraints.type] | <code>string</code> | when `select` only for menu selections, when `button` only for buttton presses, or when `dialog_submission` only for dialog submissions |
| [matchingConstraints.blockId] | <code>string</code> \| <code>RegExp</code> | a string or RegExp to match against the `block_id` |
| [matchingConstraints.actionId] | <code>string</code> \| <code>RegExp</code> | a string or RegExp to match against the `action_id` |
| [matchingConstraints.type] | <code>string</code> | valid types include all [actions block elements](https://api.slack.com/reference/messaging/interactive-components), `select` only for menu selections, or `dialog_submission` only for dialog submissions |
| [matchingConstraints.unfurl] | <code>boolean</code> | when `true` only match actions from an unfurl |
| callback | [<code>ActionHandler</code>](#module_adapter--module.exports..SlackMessageAdapter..ActionHandler) | the function to run when an action is matched |

Expand All @@ -181,8 +183,10 @@ following table describes it fully
| Param | Type | Description |
| --- | --- | --- |
| matchingConstraints | <code>object</code> | the callback ID (as a string or RegExp) or an object describing the constraints to select options requests for the handler. |
| [matchingConstraints.callbackId] | <code>string</code> \| <code>RegExp</code> | a string or RegExxp to match against the `callback_id` |
| [matchingConstraints.within] | <code>string</code> | when `interactive_message` only for menus in an interactive message, or when `dialog` only for menus in a dialog |
| [matchingConstraints.callbackId] | <code>string</code> \| <code>RegExp</code> | a string or RegExp to match against the `callback_id` |
| [matchingConstraints.blockId] | <code>string</code> \| <code>RegExp</code> | a string or RegExp to match against the `block_id` |
| [matchingConstraints.actionId] | <code>string</code> \| <code>RegExp</code> | a string or RegExp to match against the `action_id` |
| [matchingConstraints.within] | <code>string</code> | `block_actions` only for external select in actions block, `interactive_message` only for menus in an interactive message, or `dialog` only for menus in a dialog |
| callback | [<code>OptionsHandler</code>](#module_adapter--module.exports..SlackMessageAdapter..OptionsHandler) | the function to run when an options request is matched |


Expand Down
2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "@slack/interactive-messages",
"version": "1.0.2",
"version": "1.1.0",
"description": "Slack Interactive Messages module",
"main": "dist/index.js",
"repository": "https://github.com/slackapi/node-slack-interactive-messages.git",
Expand Down

3 comments on commit 9cfdcba

@awcchungster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure your changes here bricked my app. I'm not sure what happened on my node server, but it looks like somehow the latest version got pulled, but my dev machine had the older one.

Basically, I have an interactive message tool that has an action_id, now my Node middleware setup is filtering out those messages. I spent around 5 hours last week integrating it, and 1 week later it's broken with the new changes...🤦‍♂️

@aoberoi
Copy link
Contributor

@aoberoi aoberoi commented on 9cfdcba Mar 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awcchungster sorry about that! if you think there's a bug, we're happy to try and work with you to get it fixed. please create a new github issue for this (its not easy to track as a comment on a commit).

the changes in this version were specifically to help developers use two new types of constraints for actions: block_id and action_id, but should not have affected any existing handlers if you never used those constraints. if you've observed otherwise, let's discuss it! the new issue template includes a bunch of questions we would need you to answer about how we might reproduce your issue.

@awcchungster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create an issue here, could you also invite me to the slack group where I can message you guys directly? This is p0 for me to fix.

Please sign in to comment.