This repository has been archived by the owner on Jul 23, 2019. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Shane DeWael
committed
Feb 27, 2019
1 parent
af1688c
commit 9cfdcba
Showing
2 changed files
with
8 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9cfdcba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure your changes here bricked my app. I'm not sure what happened on my node server, but it looks like somehow the latest version got pulled, but my dev machine had the older one.
Basically, I have an interactive message tool that has an action_id, now my Node middleware setup is filtering out those messages. I spent around 5 hours last week integrating it, and 1 week later it's broken with the new changes...🤦♂️
9cfdcba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@awcchungster sorry about that! if you think there's a bug, we're happy to try and work with you to get it fixed. please create a new github issue for this (its not easy to track as a comment on a commit).
the changes in this version were specifically to help developers use two new types of constraints for actions:
block_id
andaction_id
, but should not have affected any existing handlers if you never used those constraints. if you've observed otherwise, let's discuss it! the new issue template includes a bunch of questions we would need you to answer about how we might reproduce your issue.9cfdcba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create an issue here, could you also invite me to the slack group where I can message you guys directly? This is p0 for me to fix.