Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert logger change #884

Merged
merged 1 commit into from Oct 9, 2019
Merged

Revert logger change #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 0 additions & 22 deletions packages/logger/src/index.spec.js
View file
Open in desktop
Expand Up @@ -17,26 +17,4 @@ describe('logger', () => {
assert.equal(logger.getLevel(), level);
});
});

it('should offer getLevel to test which level is currently set', () => {
let largeObjectGenerated = false;
function generateSomethingExpensive() {
largeObjectGenerated = true;
return JSON.stringify('{ description: "Something expensive to load" }');
}

const logger = new ConsoleLogger();
logger.setLevel(LogLevel.INFO);
if (logger.getLevel() === LogLevel.DEBUG) {
const largeObj = generateSomethingExpensive();
logger.debug(`debug: ${largeObj}`);
}
assert.isFalse(largeObjectGenerated);

logger.setLevel(LogLevel.DEBUG);
if (logger.getLevel() === LogLevel.DEBUG) {
generateSomethingExpensive();
}
assert.isTrue(largeObjectGenerated);
});
});
9 changes: 0 additions & 9 deletions packages/logger/src/index.ts
View file
Open in desktop
Expand Up @@ -48,11 +48,6 @@ export interface Logger {
*/
setLevel(level: LogLevel): void;

/**
* Return the current LogLevel.
*/
getLevel(): LogLevel;

/**
* This allows the instance to be named so that they can easily be filtered when many loggers are sending output
* to the same destination.
Expand Down Expand Up @@ -91,10 +86,6 @@ export class ConsoleLogger implements Logger {
this.name = '';
}

public getLevel(): LogLevel {
return this.level;
}

/**
* Sets the instance's log level so that only messages which are equal or more severe are output to the console.
*/
Expand Down