Permalink
Browse files

ngx_http_push_broadcast_status_locked would never return NGX_OK, so c…

…hecking the return value against NGX_OK is meaningless, instead always return NGX_OK in case of CONCURRENT_LASTIN
  • Loading branch information...
1 parent 9c888b7 commit 5a19e7a721f2e00b40b1934386b536165ae1ebf7 @liucougar liucougar committed Oct 25, 2010
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/ngx_http_push_module.c
@@ -549,7 +549,7 @@ static ngx_int_t ngx_http_push_handle_subscriber_concurrency(ngx_http_request_t
ngx_int_t rc = ngx_http_push_broadcast_status_locked(channel, NGX_HTTP_NOT_FOUND, &NGX_HTTP_PUSH_HTTP_STATUS_409, r->connection->log, ngx_http_push_shpool);
ngx_shmtx_unlock(&ngx_http_push_shpool->mutex);
- return rc==NGX_OK ? NGX_OK : NGX_ERROR;
+ return NGX_OK;
case NGX_HTTP_PUSH_SUBSCRIBER_CONCURRENCY_FIRSTIN:
ngx_http_push_respond_status_only(r, NGX_HTTP_NOT_FOUND, &NGX_HTTP_PUSH_HTTP_STATUS_409);

0 comments on commit 5a19e7a

Please sign in to comment.