special characters support #2

Closed
slash2009 opened this Issue Jan 15, 2012 · 5 comments

Comments

Projects
None yet
3 participants
@slash2009
Owner

slash2009 commented Jan 15, 2012

Cannot save fields containing special characters (&, “, é, etc …).
Need to try to encode before formatting url to send to the http api

@ghost ghost assigned slash2009 Jan 15, 2012

@un1versal un1versal closed this Mar 25, 2013

@un1versal un1versal reopened this Mar 25, 2013

@un1versal

This comment has been minimized.

Show comment
Hide comment
@un1versal

un1versal Sep 19, 2013

Contributor

@slash2009

Is this still valid? HTTP API is no longer used.

Contributor

un1versal commented Sep 19, 2013

@slash2009

Is this still valid? HTTP API is no longer used.

@fyfe

This comment has been minimized.

Show comment
Hide comment
@fyfe

fyfe Nov 27, 2013

Contributor

This patch (fyfe/XWMM@033ba1c2f48964b3bcd8c9574555719b6773b4b1 #30) ensures that all characters are correctly encoded for JSON. It's been tested on frodo with a selection of characters (&, “, á, é, í, ó, ú,', ", {}, [])

Contributor

fyfe commented Nov 27, 2013

This patch (fyfe/XWMM@033ba1c2f48964b3bcd8c9574555719b6773b4b1 #30) ensures that all characters are correctly encoded for JSON. It's been tested on frodo with a selection of characters (&, “, á, é, í, ó, ú,', ", {}, [])

@un1versal

This comment has been minimized.

Show comment
Hide comment
@un1versal

un1versal Dec 1, 2013

Contributor

@fyfe Submit a PR to XWMM master if you think this is better than current, and Ill meger and cherry pick to Frodo branch whenever I have time.

Contributor

un1versal commented Dec 1, 2013

@fyfe Submit a PR to XWMM master if you think this is better than current, and Ill meger and cherry pick to Frodo branch whenever I have time.

@fyfe

This comment has been minimized.

Show comment
Hide comment
@fyfe

fyfe Dec 1, 2013

Contributor

Done #30

Contributor

fyfe commented Dec 1, 2013

Done #30

@un1versal

This comment has been minimized.

Show comment
Hide comment
@un1versal

un1versal Dec 4, 2013

Contributor

Ok this is merged into master, and users can test it, so this is now closes this issue for now.

Contributor

un1versal commented Dec 4, 2013

Ok this is merged into master, and users can test it, so this is now closes this issue for now.

@un1versal un1versal closed this Dec 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment