Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Delete the old movies folder and rename movies2 to movies #55

Closed
wants to merge 50 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

fyfe commented Mar 1, 2014

I forgot to do some tidying up before #44 was merged. This sorts it all out.

Contributor

un1versal commented Mar 1, 2014

@fyfe Here is a few things I noticed off the bat with this.

1 The columns Set and watched is reverted back to S and W
2 Columns are not resizeable anymore < that no so much of problem as long as 1) is correct and showing by default.
3 Movie poster is ok but the other art is now directly below it, before it was to left somewhere
4 Movies by genre doesnt work
5 Recent movies doesnt work
6 Movie set management is not even an option. Cant add sets or manage set wise.
7 You can remove movies but you cant rescan or read them.
8 Also when any column/file is selected the selected text is unreadable.

Ya, but I like the way it uses the whole screen portion...

fyfe added some commits Mar 1, 2014

Revert "Delete the old movies folder and rename movies2 to movies [aa…
…39136]"

Looking back this work isn't anywhere near ready for inclusion. I never finished
implementing several of the features.

This reverts commit ec9b70f.
Revert "Merge pull request #44 from fyfe/big-cleanup"
This wasn't ready to be merged.

This reverts commit aa39136, reversing
changes made to a79ce42.
Contributor

fyfe commented Mar 1, 2014

@universai looking back at this code it was never close to being complete. Part of the reason I started looking at doing a re-write was because I was getting so frustrated trying to reinvent the wheel every time I wanted to do something in ExtJS 3.

These two reverts undo the changes made my this PR and #44.

Contributor

un1versal commented Mar 1, 2014

Thats why I asked what you wanted to do with original PR.

So basically we reverting #44 so merging this PR does this stuff?

Rewrite is a much longer term project, meanwhile XWMM need to be fixed and made ready for Gotham, but yes, its not easy juggling the two.

Contributor

un1versal commented Mar 1, 2014

@fyfe I reverted the merge of #44 for now :-( Much easier/cleaner than Merging another PR undoing the previous.

If thats the intention feel free to close this PR and then decide what you want to do with this and repopen when its ready to go somewhere.

fyfe added some commits Dec 10, 2013

Initial commit of movies (big) cleanup.
I've created it as a seperate folder for now. Once it's complete it
will all be moved into more logical folders.
Revert "Delete the old movies folder and rename movies2 to movies [aa…
…39136]"

Looking back this work isn't anywhere near ready for inclusion. I never finished
implementing several of the features.

This reverts commit ec9b70f.
Revert "Merge pull request #44 from fyfe/big-cleanup"
This wasn't ready to be merged.

This reverts commit aa39136, reversing
changes made to a79ce42.

@un1versal un1versal added the Fixed label Mar 12, 2014

Contributor

un1versal commented Mar 12, 2014

@fyfe

This can be closed as I already reverted master without destroying your cleanup repo. idk what you want to do with any of it, but this is not needed atm.

When your clean-up branch is ready let me know.

@un1versal un1versal closed this Mar 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment