You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.
BuilderaddLink(SpanContextspanContext);
BuilderaddLink(SpanContextspanContext, Attributesattributes);
// * <p>Links are used to link {@link Span}s in different traces. Used (for example) in batching operations, where a single batch handler processes multiple requests from different traces or the same trace.BuilderaddLink(Linklink);
Same as with any other add things we can add adding... ones if we want via extensions later on.
as for the comment on the spec:
An API to record a single Link where the Link properties are passed as arguments. This MAY be called AddLink.
An API to record a single Link whose attributes or attribute values are lazily constructed, with the intention of avoiding unnecessary work if a link is unused. If the language supports overloads then this SHOULD be called AddLink otherwise AddLazyLink MAY be considered.
I think we can handle the lazy case inside the SpanAttributes#68
To be honest this starts to lead us into that these context things should become Copy-on-Write types, so we can share them -- and this is a perfect example since we'll never mutate the span attributes here 🤔
As step 0 we can just be eager for now, but let's then make a ticket about the lazy part -- I think we should solve it by copy-on-write style things rather than some () -> SpanAttributes which would have been the other option.
The text was updated successfully, but these errors were encountered:
Some notes about how links can be done:
The Java impl does:
We can basically look the same here:
Same as with any other
add
things we can addadding...
ones if we want via extensions later on.as for the comment on the spec:
I think we can handle the lazy case inside the
SpanAttributes
#68To be honest this starts to lead us into that these context things should become Copy-on-Write types, so we can share them -- and this is a perfect example since we'll never mutate the span attributes here 🤔
As step 0 we can just be eager for now, but let's then make a ticket about the lazy part -- I think we should solve it by copy-on-write style things rather than some
() -> SpanAttributes
which would have been the other option.The text was updated successfully, but these errors were encountered: