New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation in MSVC through CMake. #34

Merged
merged 1 commit into from Mar 11, 2013

Conversation

Projects
None yet
2 participants
@lucasb-eyer
Contributor

lucasb-eyer commented Mar 10, 2013

When using the CMake projects to compile, MSVC will show tons of errors. This is because it should treat the files as C++ code, not C code. (Because MSVC's C compiler is still in the stone-age.)

The whole point of CMake is to have only one "project file" for all systems. I am currently including Chipmunk in my project through CMake and it works on all platforms but MSVC. This fixes it.

slembcke added a commit that referenced this pull request Mar 11, 2013

Merge pull request #34 from lucasb-eyer/master
Fix compilation in MSVC through CMake.

@slembcke slembcke merged commit a63859c into slembcke:master Mar 11, 2013

@slembcke

This comment has been minimized.

Show comment
Hide comment
@slembcke

slembcke Mar 11, 2013

Owner

Ah, thanks. I've never actually run much other than the makefile target. The xcode projects generated by Cmake work, but are sort of a mess. Which is why I usually like to have native project files when possible too.

Owner

slembcke commented Mar 11, 2013

Ah, thanks. I've never actually run much other than the makefile target. The xcode projects generated by Cmake work, but are sort of a mess. Which is why I usually like to have native project files when possible too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment