Stephan Leroux sleroux

Organizations

@twg @postageapp
sleroux commented on pull request mozilla/firefox-ios#170
@sleroux

Before this PR goes into the filing bin, just a quick note that AppDelegate.swift:L95 still needs an email to be filled in.

sleroux commented on pull request mozilla/firefox-ios#190
@sleroux

Hey Nick, no problem and thanks for merging this in. For something like this I will normally write a unit test that covers the behavior of the data…

sleroux opened pull request mozilla/firefox-ios#190
@sleroux
Bug 1135981 - Search View Results Crash
1 commit with 1 addition and 1 deletion
sleroux commented on pull request mozilla/firefox-ios#170
@sleroux

No problem. I'll keep an eye out for any changes needed tonight/tomorrow.

@sleroux
  • edf2b5c
    Add observer to snapshot event that launches the email composer with …
@sleroux
sleroux opened pull request mozilla/firefox-ios#170
@sleroux
Bug 1134231 - Send email feedback with app snapshot
1 commit with 66 additions and 0 deletions
@sleroux
sleroux commented on pull request mozilla/firefox-ios#154
@sleroux

Alright sounds good! Feel free to close this PR if you want - I can hunt something else down :+1:

sleroux created repository sleroux/overdrive_js
sleroux commented on pull request mozilla/firefox-ios#154
@sleroux

I notice that the buttons are getting laid out manually in the container's layoutSubviews call here: https://github.com/mozilla/firefox-ios/blob/ma…

sleroux commented on pull request mozilla/firefox-ios#154
@sleroux

Ah yup I see the problem. I was doing a test by changing the content size to simulate a larger panel. Let me fix this up.

sleroux opened pull request mozilla/firefox-ios#154
@sleroux
Bug 1131284 - Create pager UI for home panels
1 commit with 33 additions and 18 deletions
sleroux created repository sleroux/imgui-swift
@sleroux
Fixed first sentence in description
1 commit with 2 additions and 2 deletions
@sleroux
  • 7c1afe9
    Fixed first sentence in description