New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Travis to Node v9 to avoid v10 failures #242

Merged
merged 1 commit into from Apr 26, 2018

Conversation

Projects
None yet
1 participant
@josephfrazier
Collaborator

josephfrazier commented Apr 26, 2018

v10 fails currently: https://travis-ci.org/slevithan/xregexp/builds/370310563#L510-L528

Failures:
1) XRegExp() supports new regex syntax: named capture should throw an exception if characters other than A-Z, a-z, 0-9, $, and _ are used in capture names
  Message:
    Expected function to throw an Error.
  Stack:
    Error: Expected function to throw an Error.
        at UserContext.<anonymous> (/home/travis/build/slevithan/xregexp/tests/spec/s-xregexp.js:407:61)
  Message:
    Expected function to throw an Error.
  Stack:
    Error: Expected function to throw an Error.
        at UserContext.<anonymous> (/home/travis/build/slevithan/xregexp/tests/spec/s-xregexp.js:408:63)
  Message:
    Expected function to throw an Error.
  Stack:
    Error: Expected function to throw an Error.
        at UserContext.<anonymous> (/home/travis/build/slevithan/xregexp/tests/spec/s-xregexp.js:409:59)

398 specs, 1 failure

See also #241 (comment)

Pin Travis to Node v9 to avoid v10 failures
v10 fails currently: https://travis-ci.org/slevithan/xregexp/builds/370310563#L510-L528

```
Failures:
1) XRegExp() supports new regex syntax: named capture should throw an exception if characters other than A-Z, a-z, 0-9, $, and _ are used in capture names
  Message:
    Expected function to throw an Error.
  Stack:
    Error: Expected function to throw an Error.
        at UserContext.<anonymous> (/home/travis/build/slevithan/xregexp/tests/spec/s-xregexp.js:407:61)
  Message:
    Expected function to throw an Error.
  Stack:
    Error: Expected function to throw an Error.
        at UserContext.<anonymous> (/home/travis/build/slevithan/xregexp/tests/spec/s-xregexp.js:408:63)
  Message:
    Expected function to throw an Error.
  Stack:
    Error: Expected function to throw an Error.
        at UserContext.<anonymous> (/home/travis/build/slevithan/xregexp/tests/spec/s-xregexp.js:409:59)

398 specs, 1 failure
```

See also #241 (comment)

@josephfrazier josephfrazier merged commit 1050835 into slevithan:master Apr 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@josephfrazier josephfrazier deleted the josephfrazier:travis-node-9 branch Apr 26, 2018

@josephfrazier josephfrazier referenced this pull request Apr 26, 2018

Merged

`package-lock.json` #241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment