SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator sniff alters the script logic

[morozov]

Consider the following code example:

<?php

function test(array $options)
{
    return (int) isset($options['value']) ? $options['value'] : 1;
}

var_dump(test([]));
// int(1)

// ------------------------------------------------------------------------------------------------
// FOUND 1 ERROR AFFECTING 1 LINE
// ------------------------------------------------------------------------------------------------
//  5 | ERROR | [x] Use null coalesce operator instead of ternary operator.
//    |       |     (SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed)
// ------------------------------------------------------------------------------------------------

After fixing using PHPCBF, this code gets converted into:

<?php

function test(array $options)
{
    return (int) $options['value'] ?? 1;
}

var_dump(test([]));

// Notice: Undefined index: value in test.php on line 5
// 
// Call Stack:
//     0.0002     469520   1. {main}() test.php:0
//     0.0003     469520   2. test() test.php:8
// 
// test.php:8:
// int(0)

[morozov]

Actually, there’s a bug in the original code since it’s the result of isset() that is cast to (int), not the return value. But nevertheless. The (int) casting could be considered part of the isset() during the conversion and removed altogether.

[kukulich]

Thank you for your report.

Fixed in 670415d

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.