Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape key doesn't work on wayland #480

Closed
UtkarshVerma opened this issue Jul 3, 2022 · 4 comments
Closed

Escape key doesn't work on wayland #480

UtkarshVerma opened this issue Jul 3, 2022 · 4 comments
Assignees

Comments

@UtkarshVerma
Copy link

Describe the bug
Pressing escape during a break doesn't exit safeeyes.

To Reproduce
Steps to reproduce the behavior:

  1. Take a break
  2. Press escape
  3. Nothing happens

Expected behavior
Safeeyes break should be stopped.

Desktop (please complete the following information):

  • OS: Arch Linux
  • Desktop Env: SwayWM / Wayland
  • Version: 2.1.3
@deltragon deltragon self-assigned this Jul 16, 2024
@archisman-panigrahi
Copy link
Collaborator

Given that we currently have a setting that does not allow breaks to be skipped, do we really want to add escape to skip a break? That would render #603 kind of useless

@deltragon
Copy link
Collaborator

@archisman-panigrahi This is referring to a feature that already exists on X11 - there, pressing Escape on the Break Screen does the same thing as clicking the "Skip" button. It also respects the setting from #603.
This issue is just complaining that Wayland is regressing here compared to X11.

@archisman-panigrahi
Copy link
Collaborator

I cannot reproduce with Arch Linux KDE 6.1.3 + Wayland + Safe Eyes 2.2.1.
The escape key closes the break screen.

If anyone can reproduce the issue, please reopen.

@deltragon
Copy link
Collaborator

Oh, that's surprising to me - I could have sworn I managed to reproduce this one.
I'll check tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants