New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with ExtrusionLoop (commit c37ef2f ?) #2028

Closed
ledvinap opened this Issue May 12, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@ledvinap
Collaborator

ledvinap commented May 12, 2014

Commit c37ef2f probably introduced few problems.

at https://github.com/alexrj/Slic3r/blob/master/lib/Slic3r/GCode.pm#L220, role is not property of $loop, so slicer fail with if --randomize-start is enabled.

with --no-randomize-start, extrude_loop could be called with empty ExtrusionLoop (about 8-th call with test-squares.stl), failing nearest point lookup on https://github.com/alexrj/Slic3r/blob/master/lib/Slic3r/GCode.pm#L226 :

terminate called after throwing an instance of 'std::out_of_range'
  what():  vector::_M_range_check
Aborted

After testing for empty ExtrusionLoop, it generates gcode, but perimeters on second layer are missing.

Files here: https://drive.google.com/folderview?id=0B9HM4UOKDQBLYWZNcWRFa3ZscG8&usp=sharing

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj May 12, 2014

Member

Good, thank you: more unit tests are needed.

Member

alexrj commented May 12, 2014

Good, thank you: more unit tests are needed.

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj May 12, 2014

Member

Second bug is caused by the known Clipper bug about open paths with coincident endpoints. Our workaround is not catching some cases...

Member

alexrj commented May 12, 2014

Second bug is caused by the known Clipper bug about open paths with coincident endpoints. Our workaround is not catching some cases...

alexrj added a commit that referenced this issue May 12, 2014

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj May 12, 2014

Member

Actually, it looks like a distinct Clipper bug. I isolated it into a couple failing test cases and reported it to upstream maintainer: http://sourceforge.net/p/polyclipping/bugs/96/

Member

alexrj commented May 12, 2014

Actually, it looks like a distinct Clipper bug. I isolated it into a couple failing test cases and reported it to upstream maintainer: http://sourceforge.net/p/polyclipping/bugs/96/

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj May 26, 2014

Member

This is now fixed in Clipper.

Member

alexrj commented May 26, 2014

This is now fixed in Clipper.

alexrj added a commit that referenced this issue May 26, 2014

alexrj added a commit that referenced this issue May 26, 2014

@bmbeverst

This comment has been minimized.

Show comment
Hide comment
@bmbeverst

bmbeverst Aug 21, 2014

Can confirm this occurs on Lubuntu 14.04.01 with latest git version. Reverting to version 1.1.7 fixes the problem.

bmbeverst commented Aug 21, 2014

Can confirm this occurs on Lubuntu 14.04.01 with latest git version. Reverting to version 1.1.7 fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment