New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0 dev Skirt&Brim wrong result when both active #2157

Closed
kino3d opened this Issue Jul 7, 2014 · 6 comments

Comments

Projects
None yet
2 participants
@kino3d
Copy link

kino3d commented Jul 7, 2014

Hi alexrj, more a suggestion than a real bug?
1.2.0 dev current Ubuntu 13.04 default config
Brim & skirt seem work just fine, but i think you must make skirt/brim mutually exclusive or put the skirt outside the brim,
with skirt (default value)& brim (16mm) active i get this
screenshot from 2014-07-07 18 12 38

ciao

@alranel alranel added this to the 1.2.0 milestone Jul 13, 2014

@alranel

This comment has been minimized.

Copy link
Member

alranel commented Jul 24, 2014

Yeah, I think the only reasonable solution for handling this conflict is to stop computing the convex hull for skirt and just perform regular offsets following the object shape just like we do for brim. This way we can just skip skirt on first layer if brim is large enough to support higher skirt layers.

Usage of convex hull for skirt was discussed a long time ago, and it was preferred over simple offsets, so I expect such a change would raise complaints. We'll handle those complaints, if ever, by adding an option to set the skirt shape (convex vs. offset).

@alranel

This comment has been minimized.

Copy link
Member

alranel commented Jul 24, 2014

Or, as you suggest, put skirt outside brim… Hmm, that idea sounds like the easiest one.

@ghost

This comment has been minimized.

Copy link

ghost commented Jul 24, 2014

I vote for putting the skirt on the brim. I think that makes it more useful as a wipe wall for multiple extruders where the print also needs a brim. If the skirt is too far away, its utility as a wipe wall is minimized.

alranel added a commit that referenced this issue Jul 24, 2014

@alranel

This comment has been minimized.

Copy link
Member

alranel commented Jul 24, 2014

I implemented your idea. Thank you

@alranel alranel closed this Jul 24, 2014

@alranel alranel added the Fixed label Jul 24, 2014

@alranel

This comment has been minimized.

Copy link
Member

alranel commented Jul 25, 2014

@drahcirgnarts, putting skirt on the brim requires the change in skirt shape as we couldn't use the convex hull anymore. Usually, the brim is no larger than 5-6mm, which is also the usual distance skirt is printed at...

@kino3d

This comment has been minimized.

Copy link

kino3d commented Jul 26, 2014

Great! thanks to you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment