New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement - Cleanup duplicated M204 - Set default acceleration #2183

Closed
thiagopeixoto16 opened this Issue Jul 28, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@thiagopeixoto16

thiagopeixoto16 commented Jul 28, 2014

When activating acceleration setting I can see some double commands like below.
On the first occurrence we have a change of acceleration without need.
double-m204

It causes extra bytes on g-code, additional processing time to generate g-code and unnecessary communication cycles with the printer.

In the attached case, we have 7,968 duplicated occurrences from 45,836, so a rate of around 17% of duplicated commands.
double-cases-count

Is it possible to remove the unnecessary commands?

Case details:
https://www.dropbox.com/s/cu046lps0by5o4b/M204_Cleanup.zip

Thanks,

alexrj added a commit that referenced this issue Aug 3, 2014

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj Aug 3, 2014

Member

Thank you, done

Member

alexrj commented Aug 3, 2014

Thank you, done

@alexrj alexrj closed this Aug 3, 2014

@alexrj alexrj added this to the 1.2.0 milestone Aug 3, 2014

@alexrj alexrj added the Fixed label Aug 3, 2014

@thiagopeixoto16

This comment has been minimized.

Show comment
Hide comment
@thiagopeixoto16

thiagopeixoto16 Aug 7, 2014

I has to come here and congratulate you for the improvement.
You not only removed the sequential duplicated cases but all the duplication cases along the movement commands.
Just to illustrate, I had a file with around 14,000 M204 commands, but now with the fix it contains only 5,500 (!).

Thanks!

thiagopeixoto16 commented Aug 7, 2014

I has to come here and congratulate you for the improvement.
You not only removed the sequential duplicated cases but all the duplication cases along the movement commands.
Just to illustrate, I had a file with around 14,000 M204 commands, but now with the fix it contains only 5,500 (!).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment