New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmware retract issues G92 E0 between G10/11 #2201

Closed
wolfmanjm opened this Issue Aug 6, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@wolfmanjm

wolfmanjm commented Aug 6, 2014

When firmware retract is set the gcode generated is...

G10 ; retract
G92 E0
G11 ; unretract

This seems to be incorrect as it resets the E position before the unretract. I believe the G92 E0 should go after the G11.

It currently has no effect in Smoothie for various obscure reasons, and WW added a hack to Marlin to work around it. So it currently works, but would be nice if it were corrected for future happiness :)

@whosawhatsis

This comment has been minimized.

Show comment
Hide comment
@whosawhatsis

whosawhatsis Aug 6, 2014

For the record, it's not a hack in Marlin. It had to work the way I wrote it anyway.

whosawhatsis commented Aug 6, 2014

For the record, it's not a hack in Marlin. It had to work the way I wrote it anyway.

alexrj added a commit that referenced this issue Aug 8, 2014

alexrj added a commit that referenced this issue Aug 8, 2014

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj Aug 8, 2014

Member

Right, I added G92 E0 after G11. Removing it after G10 was not necessary, but I did it anyway to save bytes...

Member

alexrj commented Aug 8, 2014

Right, I added G92 E0 after G11. Removing it after G10 was not necessary, but I did it anyway to save bytes...

@alexrj alexrj closed this Aug 8, 2014

@alexrj alexrj added this to the 1.2.1 milestone Aug 8, 2014

@alexrj alexrj added the Fixed label Aug 8, 2014

@wolfmanjm

This comment has been minimized.

Show comment
Hide comment
@wolfmanjm

wolfmanjm Jan 10, 2015

this seems to have regressed in 1.2.5-dev

G10 ; retract
G92 E0
G1 X-14.210 Y14.193 F18000.000
G11 ; unretract
G92 E0

wolfmanjm commented Jan 10, 2015

this seems to have regressed in 1.2.5-dev

G10 ; retract
G92 E0
G1 X-14.210 Y14.193 F18000.000
G11 ; unretract
G92 E0

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj Jan 10, 2015

Member

@wolfmanjm, what's wrong with that snippet? I see G92 E0 after both G10 and G11 and that looks correct

Member

alexrj commented Jan 10, 2015

@wolfmanjm, what's wrong with that snippet? I see G92 E0 after both G10 and G11 and that looks correct

@wolfmanjm

This comment has been minimized.

Show comment
Hide comment
@wolfmanjm

wolfmanjm Jan 10, 2015

I thought you said "...Removing it after G10 was not necessary, but I did it anyway to save bytes"

wolfmanjm commented Jan 10, 2015

I thought you said "...Removing it after G10 was not necessary, but I did it anyway to save bytes"

@alexrj alexrj reopened this Jan 10, 2015

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj Jun 2, 2015

Member

It's good if it's after both… after all. ;) Since E is undefined status for most firmwares after G10/11.

Member

alexrj commented Jun 2, 2015

It's good if it's after both… after all. ;) Since E is undefined status for most firmwares after G10/11.

@alexrj alexrj closed this Jun 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment