New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No close buttons for pop-ups #2688

Closed
fotis400 opened this Issue Feb 23, 2015 · 11 comments

Comments

Projects
None yet
5 participants
@fotis400

fotis400 commented Feb 23, 2015

I have this problem for months now, but for some reason I never posted the issue...

I am using Fedora 21 x86_64, (but also previously tested in Fedora 20), with Gnome 3.14.

Each time a pop-up window opens, there is no bar on top of it, so there is no close button. The only way to close the window it by pressing [Alt]+[F4]. Previously it was rather annoying, (as 3D view was a separate window), now not so much, but it is still a bug.

Take a look at the "about" window.
screenshot from 2015-02-23 17 17 39

@alexrj alexrj added this to the 1.2.7 milestone Feb 23, 2015

@alexrj alexrj added the OS: Linux label Feb 23, 2015

@axs-gentoo

This comment has been minimized.

Show comment
Hide comment
@axs-gentoo

axs-gentoo Feb 24, 2015

What version of wxGTK and Alien-wxWidgets are you using, in Fedora 21? the lack of window decorations/controls would seem to be an issue between those two packages rather than (i expect) something specific to Slic3r. Do you see this issue with any other package that renders windows with the help of wxGTK?

axs-gentoo commented Feb 24, 2015

What version of wxGTK and Alien-wxWidgets are you using, in Fedora 21? the lack of window decorations/controls would seem to be an issue between those two packages rather than (i expect) something specific to Slic3r. Do you see this issue with any other package that renders windows with the help of wxGTK?

@fotis400

This comment has been minimized.

Show comment
Hide comment
@fotis400

fotis400 Feb 24, 2015

Well I can't tell for sure.

Fedora is naming differently wx versions than other distros. There are separate packages for version 3 and above, and separate for below 3.

Currently I have installed wxGTK (v.2.8.12-13fc21) and wxGTK3 (v.3.0.2-2.fc21), also I have installed perl-Alien-wxWidgets (v.0.51-13fc21)

I can't tell which one is being used. Maybe version v.2.8 as the package is named as in other distros... How can I find it, and how can change which one is used? (I'm building from sources).

I haven't faced any problems before with wx.

fotis400 commented Feb 24, 2015

Well I can't tell for sure.

Fedora is naming differently wx versions than other distros. There are separate packages for version 3 and above, and separate for below 3.

Currently I have installed wxGTK (v.2.8.12-13fc21) and wxGTK3 (v.3.0.2-2.fc21), also I have installed perl-Alien-wxWidgets (v.0.51-13fc21)

I can't tell which one is being used. Maybe version v.2.8 as the package is named as in other distros... How can I find it, and how can change which one is used? (I'm building from sources).

I haven't faced any problems before with wx.

@axs-gentoo

This comment has been minimized.

Show comment
Hide comment
@axs-gentoo

axs-gentoo Feb 24, 2015

Alien-wxWidgets 0.64 supports no newer than wxGTK-2.9, so I expect 0.51 would only go as new as 2.8. You need 0.65 plus a couple of patches to support wxGTK-3, and it's possible you might need wxGTK3 to have proper window decorations/controls in Gnome-3.14 ...

axs-gentoo commented Feb 24, 2015

Alien-wxWidgets 0.64 supports no newer than wxGTK-2.9, so I expect 0.51 would only go as new as 2.8. You need 0.65 plus a couple of patches to support wxGTK-3, and it's possible you might need wxGTK3 to have proper window decorations/controls in Gnome-3.14 ...

@axs-gentoo

This comment has been minimized.

Show comment
Hide comment
@axs-gentoo

axs-gentoo Feb 25, 2015

OK, so on Gentoo with Gnome-3.14, using Alien-wxWidgets 0.64 and wxGTK-2.8, apparently we do see a title bar, but no buttons; have to right-click on the titlebar and then choose close from the drop-down. So there is possibly an issue here either with older wxGTK on Ghome-3.14, or the way the dialog windows/widgets are being created within slic3r that's not entirely Gnome-3.14 optimal.

OR, it's a limitation in gnome-3 itself. You might need this, or something similar: https://github.com/danielkza/Gnome-Shell-Window-Buttons-Extension

axs-gentoo commented Feb 25, 2015

OK, so on Gentoo with Gnome-3.14, using Alien-wxWidgets 0.64 and wxGTK-2.8, apparently we do see a title bar, but no buttons; have to right-click on the titlebar and then choose close from the drop-down. So there is possibly an issue here either with older wxGTK on Ghome-3.14, or the way the dialog windows/widgets are being created within slic3r that's not entirely Gnome-3.14 optimal.

OR, it's a limitation in gnome-3 itself. You might need this, or something similar: https://github.com/danielkza/Gnome-Shell-Window-Buttons-Extension

@tomgeor

This comment has been minimized.

Show comment
Hide comment
@tomgeor

tomgeor Feb 26, 2015

I have the same issue on my Fedora 21 workstation. I'm using Cinnamon rather than Gnome 3 proper.

tomgeor commented Feb 26, 2015

I have the same issue on my Fedora 21 workstation. I'm using Cinnamon rather than Gnome 3 proper.

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj Mar 21, 2015

Member

This is weird. On Ubuntu 12.04 I see both title bar and close button...

Member

alexrj commented Mar 21, 2015

This is weird. On Ubuntu 12.04 I see both title bar and close button...

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj Mar 28, 2015

Member

@fotis400, can you please run Slic3r from command line with the --debug option? It will tell the wxWidgets and the Wx versions.

Member

alexrj commented Mar 28, 2015

@fotis400, can you please run Slic3r from command line with the --debug option? It will tell the wxWidgets and the Wx versions.

@fotis400

This comment has been minimized.

Show comment
Hide comment
@fotis400

fotis400 Mar 29, 2015

Here's the output:
http://pastebin.com/Nmn2rsUF

wxWidgets version wxWidgets 2.8.12, Wx version 0,9927

fotis400 commented Mar 29, 2015

Here's the output:
http://pastebin.com/Nmn2rsUF

wxWidgets version wxWidgets 2.8.12, Wx version 0,9927
@Mikk36

This comment has been minimized.

Show comment
Hide comment
@Mikk36

Mikk36 May 25, 2015

This isn't specific to just Linux, also happens on my Windows build with latest git commit.

Mikk36 commented May 25, 2015

This isn't specific to just Linux, also happens on my Windows build with latest git commit.

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj Jun 2, 2015

Member

Okay, I added a close button and support for Esc key and it also closes when you click inside the window. :-)

Member

alexrj commented Jun 2, 2015

Okay, I added a close button and support for Esc key and it also closes when you click inside the window. :-)

@alexrj alexrj closed this Jun 2, 2015

@alexrj alexrj added the Fixed label Jun 2, 2015

alexrj added a commit that referenced this issue Jun 2, 2015

Add close button and support Esc key and close on click inside the wi…
…ndow to the About dialog since the title bar is not displayed on Windows and some Linux distros. #2688

@alexrj alexrj referenced this issue Jun 3, 2015

Closed

About on 1.2.7 #2880

born2b added a commit to born2b/Slic3r that referenced this issue Jun 10, 2015

Add close button and support Esc key and close on click inside the wi…
…ndow to the About dialog since the title bar is not displayed on Windows and some Linux distros. #2688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment