New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slicer crashes when the first part in the parts list is deleted [1.2.6] #2774

Closed
CNCKitchen opened this Issue Apr 5, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@CNCKitchen

I just noticed that Slic3r is always crashing when I delete the first part in my parts list.
delete
As long as I did not add any other part the delete button is grayed out. Adding a second part enables me to delete any of them. Deleting the second one in the list is fine. Deleting the first crashes Slic3r.
Windows 7 x64

Cheers
Stefan

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj May 2, 2015

Member

Can you please provide detailed steps in order to reproduce the issue?

Member

alexrj commented May 2, 2015

Can you please provide detailed steps in order to reproduce the issue?

@alexrj alexrj added this to the 1.2.7 milestone May 2, 2015

@CNCKitchen

This comment has been minimized.

Show comment
Hide comment
@CNCKitchen

CNCKitchen May 3, 2015

  • Add a new part to Slic3r (hole.stl)
  • RMB - Settings
  • "Load part..." (add a second part. I my case "support.stl")
    Now I have "hole.stl" and "support.stl" in the list. Now I want to replace the first part in the list by deleting it:
  • Select the first part "hole.stl" - Delete part
    --> Slic3r crashes on my machine

I hope you can reproduce that issue.

  • Add a new part to Slic3r (hole.stl)
  • RMB - Settings
  • "Load part..." (add a second part. I my case "support.stl")
    Now I have "hole.stl" and "support.stl" in the list. Now I want to replace the first part in the list by deleting it:
  • Select the first part "hole.stl" - Delete part
    --> Slic3r crashes on my machine

I hope you can reproduce that issue.

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj May 3, 2015

Member

Okay, thank you. I'm able to reproduce this on Windows only. It looks like an ugly wxWidgets issue.

Member

alexrj commented May 3, 2015

Okay, thank you. I'm able to reproduce this on Windows only. It looks like an ugly wxWidgets issue.

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj May 4, 2015

Member

After a long debugging session I was able to find the wxWidgets bug causing this behavior, and I pushed a workaround. The issue is now fixed, and Slic3r does not crash anymore. Thank you @cocoknight for reporting this.

Docs for wxTreeCtrl state that the DeleteChildren method "will not generate any events unlike Delete() method". However, close inspection of the wxWidgets code reveals that DeleteChildren is implemented in MSW as a call to Delete(). So it will generate events, including EVT_TREE_SEL_CHANGED.

Member

alexrj commented May 4, 2015

After a long debugging session I was able to find the wxWidgets bug causing this behavior, and I pushed a workaround. The issue is now fixed, and Slic3r does not crash anymore. Thank you @cocoknight for reporting this.

Docs for wxTreeCtrl state that the DeleteChildren method "will not generate any events unlike Delete() method". However, close inspection of the wxWidgets code reveals that DeleteChildren is implemented in MSW as a call to Delete(). So it will generate events, including EVT_TREE_SEL_CHANGED.

@alexrj alexrj closed this May 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment