New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect concave seam point detection when inside loops #2857

Closed
xoan opened this Issue May 26, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@xoan
Member

xoan commented May 26, 2015

When there is one convex point in an inside closed loop (a hole), it is choosed as the perimeter start point instead one of the other concave ones (outside concave points are detected and used)

cube-convex-inside

config.ini: https://gist.github.com/xoan/7b3c230fdda1e4fc2a2f (it is also reproducible with de defaultconfig)

OpenJSCAD compatible code to generate the STL:

//!OpenSCAD
difference() {
    cube([20,20,10], center = true);
    translate([10,10]) cube([10,10,20], center = true);
    difference() {
        cube([10,10,20], center = true);
        translate([5,5]) cube([10,10,20], center = true);
    }
}

@xoan xoan changed the title from [1.2.7-experimental] Incorrect concave seam point detection when inside loops to Incorrect concave seam point detection when inside loops May 26, 2015

@alexrj alexrj added this to the 1.2.8 milestone Jun 1, 2015

alexrj added a commit that referenced this issue Jun 1, 2015

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj Jun 1, 2015

Member

Good catch. I fixed this and added a regression test.

Member

alexrj commented Jun 1, 2015

Good catch. I fixed this and added a regression test.

@alexrj alexrj closed this Jun 1, 2015

@alexrj alexrj added the Fixed label Jun 1, 2015

born2b added a commit to born2b/Slic3r that referenced this issue Jun 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment