New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filament Specific G-Code - Feature Request #3309

Closed
mirage335 opened this Issue Apr 18, 2016 · 11 comments

Comments

Projects
None yet
4 participants
@mirage335

mirage335 commented Apr 18, 2016

Please allow Start/End/BeforeLayer/AfterLayer/ToolChange custom G-Code scripts to be appended under filament settings. Particularly for RepRapPro firmware, it may be desirable to manually set standby temperatures, allow cold extrusion, etc.

Regarding standby temperature configuration, this is also a useful workaround when the shells generated by ooze prevention settings are undesired.

@lordofhyphens

This comment has been minimized.

Member

lordofhyphens commented May 27, 2016

I'll see what I can do; it'll probably end up being an cut'n'paste from the Printer Settings gcode. Hope it doesn't get abused :D

@lordofhyphens

This comment has been minimized.

Member

lordofhyphens commented May 28, 2016

Done, going to close for now. It's not merged in yet because there's no test for it yet (and I suck at writing test cases).

@mirage335

This comment has been minimized.

mirage335 commented May 29, 2016

Thanks, looking forward to using this!

@lordofhyphens

This comment has been minimized.

Member

lordofhyphens commented May 29, 2016

Sorry, confused it with something else. Reopening sp I don't forget about it.

As for the order, what sounds most useful? For Start/end, I was thinking about having it look like this

P-start f-start (printing code) f-end P-end

For before/after layer change, I think I am going to use the same scheme. For everything else the filament code will precede ther printer code.

@mirage335

This comment has been minimized.

mirage335 commented May 29, 2016

Probably best just to let filament specific gcode proceed (after) the generic printer code in all cases. If something like temperature has been set to a default in the generic printer code, then a specific type of filament might need to override this every time the tool switches back to a tool loaded with special-temperature filament.

@lordofhyphens

This comment has been minimized.

Member

lordofhyphens commented May 29, 2016

Yeah that's what I was thinking of, the positioning is to maintain the
order around the gcode in terms of how general.
On May 29, 2016 10:25 AM, "mirage335" notifications@github.com wrote:

Probably best just to let filament specific gcode proceed (after) the
generic printer code. If something like temperature has been set to a
default in the generic printer code, then a specific type of filament might
need to override this every time the tool switches back to a tool loaded
with special-temperature filament.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#3309 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAB8CnmQdL6i2-hrGIOEDxwwt-AXGIiuks5qGa_fgaJpZM4IJ1TB
.

@VanessaE

This comment has been minimized.

Collaborator

VanessaE commented Sep 28, 2016

I was thinking today that this could be exploited to allow for per-filament autotemp as well. That would require the per-filament "start" to happen as late as possible, like right before the first layer change (so that it happens after the M109 command Slic3r adds).

@lordofhyphens

This comment has been minimized.

Member

lordofhyphens commented Sep 29, 2016

Except that if you extended it to the check of "hey we need to add m109" check it wouldn't matter for that

@bubnikv

This comment has been minimized.

Contributor

bubnikv commented Oct 27, 2016

@lordofhyphens Would you please point me to the check-in with your filament specific G-codes, so I could review it and possibly merge with the Prusa3D fork? Thanks

@lordofhyphens

This comment has been minimized.

Member

lordofhyphens commented Nov 26, 2016

@bubnikv PR is up.

@mirage335 there's the pull request, a win32 build should show up at https://bintray.com/lordofhyphens/Slic3r/Slic3r_Branches in an hour or two.

@lordofhyphens

This comment has been minimized.

Member

lordofhyphens commented Mar 11, 2017

PR was merged, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment