New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pronterface compatibility broken because presets are saved without extension in slic3r.ini #3813

Closed
xoan opened this Issue Mar 27, 2017 · 11 comments

Comments

Projects
None yet
5 participants
@xoan
Member

xoan commented Mar 27, 2017

Version

current master

Operating system

Arch Linux 4.9.16-1-lts x86_64
Xfce 4.12

Behavior

The way the default presets are saved now in slic3r.ini breaks the compatibility with the Slic3r integration in Pronterface:

Because Pronterface expects the preset name contains the full file name including .ini.

Probably it is an issue to be solved in Pronterface, right?

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj Mar 27, 2017

Member

Oh, I didn't know that. I thought it only used the public CLI commands. I think it's easy enough to modify Pronterface to append .ini if it's not there...

Member

alexrj commented Mar 27, 2017

Oh, I didn't know that. I thought it only used the public CLI commands. I think it's easy enough to modify Pronterface to append .ini if it's not there...

@lordofhyphens

This comment has been minimized.

Show comment
Hide comment
@lordofhyphens
Member

lordofhyphens commented Mar 27, 2017

@kliment FYI...

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj May 1, 2017

Member

I fixed this in kliment/Printrun#817
I could merge it into the Printrun repository myself, but I can't test it at the moment. @xoan, if you run Pronterface from git would you have a chance to test my change?

Member

alexrj commented May 1, 2017

I fixed this in kliment/Printrun#817
I could merge it into the Printrun repository myself, but I can't test it at the moment. @xoan, if you run Pronterface from git would you have a chance to test my change?

@xoan

This comment has been minimized.

Show comment
Hide comment
@xoan

xoan May 1, 2017

Member

Sorry, it doesn't work (despite the syntax error in the if sentence with no colon at the end :P). It still updates slic3r.ini with full preset filename, including extension.

To solve this issue, it probaly involves some more changes in load_slic3r_configs and read_slic3r_config.

I can take a look into it this night. Let me try.

Member

xoan commented May 1, 2017

Sorry, it doesn't work (despite the syntax error in the if sentence with no colon at the end :P). It still updates slic3r.ini with full preset filename, including extension.

To solve this issue, it probaly involves some more changes in load_slic3r_configs and read_slic3r_config.

I can take a look into it this night. Let me try.

xoan added a commit to xoan/Printrun that referenced this issue May 2, 2017

@xoan

This comment has been minimized.

Show comment
Hide comment
@xoan

xoan May 2, 2017

Member

OK, I just made a PR (kliment/Printrun#818) with changes that take into account the Slic3r version from slic3r.ini.

It is tested in GNU/Linux, with both 1.2.9 and 1.3.0-dev Slic3r version.

Member

xoan commented May 2, 2017

OK, I just made a PR (kliment/Printrun#818) with changes that take into account the Slic3r version from slic3r.ini.

It is tested in GNU/Linux, with both 1.2.9 and 1.3.0-dev Slic3r version.

@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj May 16, 2017

Member

Thank you for contributing that @xoan. I merged the PR in Printrun :)

Member

alexrj commented May 16, 2017

Thank you for contributing that @xoan. I merged the PR in Printrun :)

@xoan

This comment has been minimized.

Show comment
Hide comment
@xoan

xoan May 16, 2017

Member

Nice :)

Member

xoan commented May 16, 2017

Nice :)

@ntoff

This comment has been minimized.

Show comment
Hide comment
@ntoff

ntoff Jul 9, 2017

This seems to break integration with the Prusa edition of slic3r (1.35.5), with slic3r integration enabled, it appends .ini to the file, leading to being unable to locate the profile.

Cannot find specified configuration file (C:\Users\redacted\AppData\Roaming\Slic3r\print\default.ini.ini).

ntoff commented Jul 9, 2017

This seems to break integration with the Prusa edition of slic3r (1.35.5), with slic3r integration enabled, it appends .ini to the file, leading to being unable to locate the profile.

Cannot find specified configuration file (C:\Users\redacted\AppData\Roaming\Slic3r\print\default.ini.ini).

@bubnikv

This comment has been minimized.

Show comment
Hide comment
@bubnikv

bubnikv Jul 10, 2017

Contributor
Contributor

bubnikv commented Jul 10, 2017

@xoan

This comment has been minimized.

Show comment
Hide comment
@xoan

xoan Jul 14, 2017

Member

It should be solved by patching Prusa edition of Slic3r to follow the current Slic3r behavior.

Member

xoan commented Jul 14, 2017

It should be solved by patching Prusa edition of Slic3r to follow the current Slic3r behavior.

@ntoff

This comment has been minimized.

Show comment
Hide comment
@ntoff

ntoff Jul 15, 2017

or more easily, I just added a check to pronterface to not add .ini to the profile if it detects the prusa edition of slic3r

ntoff commented Jul 15, 2017

or more easily, I just added a check to pronterface to not add .ini to the profile if it detects the prusa edition of slic3r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment