Support multi sampled anti-aliasing with wxWidgets 3.0.3. - #3343
Conversation
This fixes two problems of repeatedly copying data from the C++ layer to perl, by factoring the copying out of an inner loop.
|
Here are the patches for Alien::Wx and Wx::GLCanvas to make MSAA working. |
|
You've got unrelated changes added now to the PR (the gcode export changes). -.-; |
|
You see, I am really struggling with the git. |
|
Some good practices for making contributions to Slic3r (IMHO, any upstream project).
The less work the project maintainers have to do to vet and merge external code, the more likely it will be that (all other things being equal) the code gets merged in. As a quick example, see #3349 . I created a branch on my personal fork of Slic3r, lordofhyphens:feature-1333 which originated at alexrj:master. I made the changes, tested them, and then committed them to that branch. Then the pull request got made. When the PR gets merged in (I tend to not merge my own commits in, so someone else can check them as a guard against me derping), I'll delete the branch from my own repo. I've had my own learning curve with this too with my first few PRs for Slic3r, so I am happy to try to help you too. :) |
This patch improves rendering of the 3D scenes. The improvement is significant on the 3D path simulation.
Increases resolution of the depth buffer from 16 bits to 24 bits. 16 bits cause some jagged lines at the intersection of triangles. I believe the computers offering a 16 bit depth buffer only are already in the landfill.
Enables multi sample anti aliasing. This is finally supported by wxWidgets 3.1 (February 29, 2016) and the OpenGL support for creation of anti aliased windows has been back ported to wxWidgets 3.0.3 (currently in beta stage). We at Prusa Research have hacked the Alien::Wx and Wx::GLCanvas to support this feature. Please accept this patch to enable anti aliasing on Prusa builds. This change shall not have any effect with the official non-hacked Alien::Wx and Wx::GLCanvas modules.
Vojtech