New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Smoothieware flavor to Gcode #3373

Merged
merged 1 commit into from Jun 24, 2016

Conversation

Projects
None yet
2 participants
@lordofhyphens
Member

lordofhyphens commented Jun 24, 2016

Avoids resetting extrusion axis after firmware retract (still resets after unretract) with smoothieware.

Adds Smoothieware flavor to Gcode, to avoid some weirdness in the new…
… motion controls.

Avoids resetting extrusion axis after firmware retract (still resets after unretract)
with smoothieware.

@lordofhyphens lordofhyphens added this to the 1.3.0 milestone Jun 24, 2016

@lordofhyphens lordofhyphens self-assigned this Jun 24, 2016

@lordofhyphens lordofhyphens merged commit cb72967 into slic3r:master Jun 24, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@lordofhyphens lordofhyphens deleted the lordofhyphens:smoothie-flavor branch Jun 24, 2016

@alranel

This comment has been minimized.

Member

alranel commented on 0673389 Jul 10, 2016

@lordofhyphens, where was this discussed? I can't find the related issue and discussion.

Also, GCodeWriter should handle ALL the flavor-specific logic. That's its purpose. Putting flavor-specific logic outside it breaks incapsulation.

This comment has been minimized.

Member

alranel replied Jul 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment