Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimistic print time estimator #3747

Closed
wants to merge 8 commits into from

Conversation

@lordofhyphens
Copy link
Member

@lordofhyphens lordofhyphens commented Mar 10, 2017

Add an optimistic print time estimator to Slic3r. Considers just the print and travel moves under ideal circumstances. The information is collected during gcode generation per-extruder and then summed at the end.

This PR requires that #3669 be merged first (adds slicing statistic box)

Implements #1766 (along with #3669).

@lordofhyphens lordofhyphens added this to the 1.3.1 milestone Mar 10, 2017
@lordofhyphens lordofhyphens self-assigned this Mar 10, 2017
@lordofhyphens lordofhyphens requested a review from alranel Mar 10, 2017
@lordofhyphens
Copy link
Member Author

@lordofhyphens lordofhyphens commented Mar 10, 2017

Obviously it will be even less accurate if you're not telling Slic3r to control acceleration.

…correctly on different platforms.

Changed output units to cm/cm^3
Copy link
Member

@alranel alranel left a comment

This adds extra computation time and does not include things like retractions which are usually slow (as well as travel moves perhaps?).
I'd prefer to implement the time estimator as a separate G-code processor. The GUI could launch that computation asynchronously in a background thread and it would be much easier to account for every G-code line including retractions and travel moves. Also we would provide the community with an almost standalone, or at least cleaner, time estimation library. Unit testing (heuristics etc.) would be easier too.

@lordofhyphens
Copy link
Member Author

@lordofhyphens lordofhyphens commented Mar 10, 2017

alranel added a commit that referenced this pull request Mar 24, 2017
@lordofhyphens
Copy link
Member Author

@lordofhyphens lordofhyphens commented Mar 24, 2017

Superseded by 969f28f

@lordofhyphens lordofhyphens deleted the lordofhyphens:slice-timing branch Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants