Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octoprint settings functionality expanded to allow upload to RepRapFi… #4028

Merged
merged 2 commits into from Jun 16, 2017

Conversation

emaker
Copy link
Contributor

@emaker emaker commented Jun 14, 2017

…rmware on a Duet controller.
Some way towards solving #4022 although I don't know about any other print servers at this time.

Copy link
Member

@lordofhyphens lordofhyphens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should rename "octoprint_host", etc to something more generic as to not confuse people reading the source.

Copy link
Member

@lordofhyphens lordofhyphens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When doing the rename, add "octoprint_*" as aliases in PrintConfig.cpp to support older configs.

@lordofhyphens
Copy link
Member

@emaker, this looks pretty good. Please incorporate the changes I noted and I think we can merge this.

@alexrj

@emaker
Copy link
Contributor Author

emaker commented Jun 15, 2017

@lordofhyphens I wasn't sure how to implement the aliases you mentioned, so I added octoprint_host as a legacy option in PrintConfig.cpp, using the Bed_Size option as a guide.

@lordofhyphens lordofhyphens merged commit 1c74067 into slic3r:master Jun 16, 2017
@lordofhyphens
Copy link
Member

Looks good, thanks for the commit. This looks generic enough that if someone wants to continue to add support for another host program that doesn't need more than what is provided we're still good to go.

@lordofhyphens
Copy link
Member

If it needs a refactor for the next one, then we'll deal with it then.

@rob-miller
Copy link

This is great to have (!!!)
But on 1.18.1 DuetWifi Slic3r automated build slic3r-1.3.0-dev-98fca90.dmg I find:

  • if the file does not exist on the SD card already, Duet reports
    'GCode file "lsm1.gcode" not found
    Failed to open file lsm1.gcode'
    (or whatever file may be called)
  • if a file with the same name exists, the existing file is queued for printing (but not the new one sent from slic3r)

this is with 'Overwrite existing file' and 'Start print' enabled. Have tried other settings, all consistent with not getting file loaded on to SD card.

@emaker
Copy link
Contributor Author

emaker commented Jun 16, 2017

@rob-miller I don't have a DuetWifi to play with, but this code was developed using a Duet 0.6 over ethernet, and with @chrishamm's firmware 1.18-b2. I didn't test with 1.19 as it didn't appear to be stable yet.
I see 1.18.1 is newer than 1.18-b2, so let me test with that.

@rob-miller
Copy link

Thanks, saw that on the duet forum. Surprised the behaviour is different on mine - initially thought it worked until realised the file was the old one. happy to debug this offline (email in my gh profile)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants