Add schema feature createIfNotExists and dropIfExists #1704
Conversation
trevorsibanda
force-pushed
the
add-ddl-feature-createifnotexists-dropifexists
branch
13 times, most recently
from
99a5e81
to
07dd153
Compare
| _ <- (as += (1, 1, "a11-conflict")).failed | ||
| _ <- as.schema.drop | ||
| } yield () | ||
| } |
There was a problem hiding this comment.
@trevorsibanda maybe you can split this test into multiple smaller ones, so it will be easier to narrow down where stuff goes wrong? Unfortunately both future and DBIO kill the usefulness of stacktraces
trevorsibanda
force-pushed
the
add-ddl-feature-createifnotexists-dropifexists
branch
7 times, most recently
from
ab37065
to
ed69a2f
Compare
trevorsibanda
force-pushed
the
add-ddl-feature-createifnotexists-dropifexists
branch
from
891d929
to
4a45bae
Compare
| @@ -61,6 +67,8 @@ trait OracleProfile extends JdbcProfile { | |||
|
|
|||
| override protected def computeCapabilities: Set[Capability] = (super.computeCapabilities | |||
| - RelationalCapabilities.foreignKeyActions | |||
| - RelationalCapabilities.createIfNotExists | |||
| - RelationalCapabilities.dropIfExists | |||
There was a problem hiding this comment.
I am confused. It looks like you added this feature to Oracle, but this says Oracle doesn't support this. Is this a mistake?
There was a problem hiding this comment.
The - here means you are removing these capabilities from the set of supported capabilities for this driver, which seems to be inaccurate. (Same for the other drivers, where you implemented the feature).
There was a problem hiding this comment.
@cvogt Thanks... I should change that and also update the others, only DerbyProfile should have these removed since it uses a client side implementation.
There was a problem hiding this comment.
I think client side implementation is fine. The flags just identify if Slick is able to do this using whatever method. So I don't think we need to remove them. In fact it sounds like we can get rid of them. Back then I only suggested them as an alternative in case it was impossible to do with one of the drivers.
|
really cool stuff :)! |
trevorsibanda
force-pushed
the
add-ddl-feature-createifnotexists-dropifexists
branch
2 times, most recently
from
6256e46
to
a5f500b
Compare
| @@ -89,6 +97,8 @@ trait DerbyProfile extends JdbcProfile { | |||
| - JdbcCapabilities.booleanMetaData | |||
| - JdbcCapabilities.supportsByte | |||
| - RelationalCapabilities.repeat | |||
| - RelationalCapabilities.createIfNotExists | |||
| - RelationalCapabilities.dropIfExists | |||
There was a problem hiding this comment.
does removing the capabilities here make sense? Looks like you added support below, so now the driver actually has this capability. No?
trevorsibanda
force-pushed
the
add-ddl-feature-createifnotexists-dropifexists
branch
from
a5f500b
to
93e1507
Compare
trevorsibanda
changed the title
trevorsibanda
force-pushed
the
add-ddl-feature-createifnotexists-dropifexists
branch
from
93e1507
to
a67a880
Compare
trevorsibanda
force-pushed
the
add-ddl-feature-createifnotexists-dropifexists
branch
from
a67a880
to
327e81c
Compare
Added IF (NOT) EXISTS support for SQLServer Added IF (NOT) EXISTS support for IBM DB2 Added IF (NOT) EXISTS support for Oracle Added IF (NOT) EXISTS emulation for Derby Added test cases for createIfNotExists and dropIfExists
|
@trevorsibanda is this ready for merge? |
|
@hvesalai Yes it is. |
|
I think this is great. It resolves my feature request from 2013 #93 |
Addresses points discussed in #93
Adds methods createIfNotExists and dropIfExists
Issues now
IF NOT EXISTSeither in create, drop or both statements. (DB2, Derby, Sqlserver - cause of failing tests).createIfNotExistsfail if the table definition has a foreign key.