Issue #1684: Invalid query generated using OracleDriver for filter with Option column. #2059
Conversation
…tion when suplied with default value through getOrElse.
|
Hi @alexFrankfurt, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
Hi @alexFrankfurt, would you be willing to finish this? If you don't have time, let me know and I'll try to take over and bring this to completion. |
| import slick.jdbc.OracleProfile | ||
|
|
||
| class OptionBooleanTest extends AsyncTest[JdbcTestDB] { | ||
| lazy val oracleProfile = tdb.profile.asInstanceOf[OracleProfile] |
There was a problem hiding this comment.
Can we change this test so that we can execute this for all databases? This is something that should work regardless of the profile that is used.
There was a problem hiding this comment.
Yes, I've made appropriate changes.
|
issue was reported 2 years ago now, and the fix was proposed 5 months ago. Can we please get this in? |
|
Guys, any news regarding this? We just migrated from squeryl to slick only to find that Slick can't properly handle boolean values..? |
|
@kubukoz thank you for the PR |
|
@hvesalai not my PR ;) |
|
Happy to make slick better 👍 |
|
So sorry guys. Credit where credit is due. Thank you @alexFrankfurt ! |
Adds test and fixes #1684
Giving value by default and comparing with boolean like here wasn't working either. This PR implements fix for that case as well.