Try for the Select Distinct. #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi. This work is for the Select Distinct. In the Slick, in order to use the select distinct, below syntax is used. qA.groupBy(t=>t).map(_._1) And, result sql is like below. select x1.colA, x1.colB from (...) x1 group by x1.colA, x1.colB In this work, below syntax is possible, also. qA.distinct And, result sql is like below. select distinct x1.colA, x1.colB from (...) x1 This doesn't introduce any Node classes. Instead, add a one flag into Comprehension. And, the .distinct method is just a macro for groupBy(t=>t).map(_._1). Thanks.
Conflicts: src/main/scala/scala/slick/compiler/Relational.scala
|
Anything happening on this one? |
|
+1 would love to see distinct support in slick |
|
Is there maybe an overlap with this #1271 ? |
|
closing for inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
At first, I did read #96
This work is for the Select Distinct.
In the Slick, in order to use the select distinct, below syntax is used.
And, result sql is like below.
In this work, below syntax is possible, also.
And, result sql is like below.
This doesn't introduce any Node classes. Instead, add a one flag into Comprehension.
And, the
.distinctmethod is just a macro forgroupBy(t=>t).map(_._1).Thanks.