Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stopWatchingPayment broken by Baron restart #53

Open
wtogami opened this issue Jun 25, 2014 · 0 comments
Open

stopWatchingPayment broken by Baron restart #53

wtogami opened this issue Jun 25, 2014 · 0 comments

Comments

@wtogami
Copy link
Collaborator

wtogami commented Jun 25, 2014

We thought stopWatchingPayment() may be redundant given checkPaymentExpiration()

function checkPaymentExpiration(payment) {
  var curTime = new Date().getTime();
  var expirationTime = Number(payment.created) + config.spotRateValidForMinutes * 60 * 1000;
  if(payment.status === 'unpaid' && expirationTime < curTime) {
    payment.watched = false;
    db.insert(payment);
  }
}

checkPaymentExpiration() does almost the same thing except time granularity is limited to the updateWatchListInterval.

However removing stopWatchingPayment() breaks something, suggesting USD handling is broken in the case of restarting Baron. Need to investigate.

@wtogami wtogami changed the title stopWatchingPayment is redundant? stopWatchingPayment broken by Baron restart Jun 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant