Skip to content

Commit 3bd6af8

Browse files
Fix image release workflows and explicitly add permission blocks (devcontainers#956)
* Update workflows and explcity add permission blocks * Updates pagination * update launch.json
1 parent 65aa32d commit 3bd6af8

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

.github/workflows/push-dev.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ jobs:
1111
if: "github.ref == 'refs/heads/main'"
1212
strategy:
1313
matrix:
14-
page: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66]
15-
page-total: [66]
14+
page: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70]
15+
page-total: [70]
1616
fail-fast: false
1717
runs-on: devcontainer-image-builder-ubuntu
1818
steps:
@@ -72,6 +72,9 @@ jobs:
7272
name: Trigger info extraction
7373
needs: [build-and-push]
7474
uses: devcontainers/images/.github/workflows/version-history.yml@main
75+
permissions:
76+
contents: write
77+
pull-requests: write
7578
with:
7679
release: "${{ github.ref }}"
7780
cg: "true"

.github/workflows/push.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ jobs:
1111
if: ${{ github.event.base_ref == 'refs/heads/main' }}
1212
strategy:
1313
matrix:
14-
page: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66]
15-
page-total: [66]
14+
page: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70]
15+
page-total: [70]
1616
fail-fast: false
1717
runs-on: devcontainer-image-builder-ubuntu
1818
steps:
@@ -72,6 +72,9 @@ jobs:
7272
name: Trigger info extraction
7373
needs: [build-and-push]
7474
uses: devcontainers/images/.github/workflows/version-history.yml@main
75+
permissions:
76+
contents: write
77+
pull-requests: write
7578
with:
7679
release: "${{ github.ref }}"
7780
cg: "false"

.vscode/launch.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"--page",
2020
"1",
2121
"--pageTotal",
22-
"66"
22+
"70"
2323
],
2424
"console": "integratedTerminal",
2525
}

0 commit comments

Comments
 (0)