Skip to content

Commit ad31564

Browse files
Javascript-Node: Support Node v20 (devcontainers#531)
1 parent 41fa665 commit ad31564

File tree

3 files changed

+64
-23
lines changed

3 files changed

+64
-23
lines changed

src/javascript-node/.devcontainer/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 18, 16, 14, 18-bullseye, 16-bullseye, 14-bullseye, 18-buster, 16-buster, 14-buster
2-
ARG VARIANT=18-bullseye
1+
# [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 20, 18, 16, 14, 20-bullseye, 18-bullseye, 16-bullseye, 14-bullseye, 20-buster, 18-buster, 16-buster, 14-buster
2+
ARG VARIANT=20-bullseye
33
FROM node:${VARIANT}
44

5-
ENV IMAGE_VARIANT="18-bullseye"
5+
ENV IMAGE_VARIANT="20-bullseye"
66

77
COPY library-scripts/add-patch.sh /tmp/library-scripts/
88
RUN bash /tmp/library-scripts/add-patch.sh "${IMAGE_VARIANT}" && rm -rf /tmp/library-scripts

src/javascript-node/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
| *Categories* | Core, Languages |
1010
| *Image type* | Dockerfile |
1111
| *Published image* | mcr.microsoft.com/devcontainers/javascript-node |
12-
| *Available image variants* | 18 / 18-bullseye, 16 / 16-bullseye, 14 / 14-bullseye, 18-buster, 16-buster, 14-buster ([full list](https://mcr.microsoft.com/v2/devcontainers/javascript-node/tags/list)) |
12+
| *Available image variants* | 20 / 20-bullseye, 18 / 18-bullseye, 16 / 16-bullseye, 14 / 14-bullseye, 20-buster, 18-buster, 16-buster, 14-buster ([full list](https://mcr.microsoft.com/v2/devcontainers/javascript-node/tags/list)) |
1313
| *Published image architecture(s)* | x86-64, arm64/aarch64 for `bullseye` variants |
1414
| *Container host OS support* | Linux, macOS, Windows |
1515
| *Container OS* | Debian |
@@ -20,6 +20,7 @@
2020
You can directly reference pre-built versions of `Dockerfile` by using the `image` property in `.devcontainer/devcontainer.json` or updating the `FROM` statement in your own `Dockerfile` to one of the following. An example `Dockerfile` is included in this repository.
2121

2222
- `mcr.microsoft.com/devcontainers/javascript-node` (latest)
23+
- `mcr.microsoft.com/devcontainers/javascript-node:20` (or `20-bullseye`, `20-buster` to pin to an OS version)
2324
- `mcr.microsoft.com/devcontainers/javascript-node:18` (or `18-bullseye`, `18-buster` to pin to an OS version)
2425
- `mcr.microsoft.com/devcontainers/javascript-node:16` (or `16-bullseye`, `16-buster` to pin to an OS version)
2526
- `mcr.microsoft.com/devcontainers/javascript-node:14` (or `14-bullseye`, `14-buster` to pin to an OS version)

src/javascript-node/manifest.json

Lines changed: 59 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,79 @@
11
{
22
"version": "0.204.20",
3-
"variants": ["18-bullseye", "16-bullseye", "14-bullseye", "18-buster", "16-buster", "14-buster"],
3+
"variants": [
4+
"20-bullseye",
5+
"18-bullseye",
6+
"16-bullseye",
7+
"14-bullseye",
8+
"20-buster",
9+
"18-buster",
10+
"16-buster",
11+
"14-buster"
12+
],
413
"build": {
5-
"latest": "18-bullseye",
14+
"latest": "20-bullseye",
615
"rootDistro": "debian",
716
"architectures": {
8-
"18-bullseye": ["linux/amd64", "linux/arm64"],
9-
"16-bullseye": ["linux/amd64", "linux/arm64"],
10-
"14-bullseye": ["linux/amd64", "linux/arm64"],
11-
"18-buster": ["linux/amd64"],
12-
"16-buster": ["linux/amd64"],
13-
"14-buster": ["linux/amd64"]
17+
"20-bullseye": [
18+
"linux/amd64",
19+
"linux/arm64"
20+
],
21+
"18-bullseye": [
22+
"linux/amd64",
23+
"linux/arm64"
24+
],
25+
"16-bullseye": [
26+
"linux/amd64",
27+
"linux/arm64"
28+
],
29+
"14-bullseye": [
30+
"linux/amd64",
31+
"linux/arm64"
32+
],
33+
"20-buster": [
34+
"linux/amd64"
35+
],
36+
"18-buster": [
37+
"linux/amd64"
38+
],
39+
"16-buster": [
40+
"linux/amd64"
41+
],
42+
"14-buster": [
43+
"linux/amd64"
44+
]
1445
},
1546
"tags": [
1647
"javascript-node:${VERSION}-${VARIANT}"
1748
],
1849
"variantTags": {
19-
"18-bullseye": [
20-
"javascript-node:${VERSION}-18",
50+
"20-bullseye": [
51+
"javascript-node:${VERSION}-20",
2152
"javascript-node:${VERSION}-bullseye"
2253
],
23-
"16-bullseye": [ "javascript-node:${VERSION}-16" ],
24-
"14-bullseye": [ "javascript-node:${VERSION}-14" ],
25-
"18-buster": [
54+
"18-bullseye": [
55+
"javascript-node:${VERSION}-18"
56+
],
57+
"16-bullseye": [
58+
"javascript-node:${VERSION}-16"
59+
],
60+
"14-bullseye": [
61+
"javascript-node:${VERSION}-14"
62+
],
63+
"20-buster": [
2664
"javascript-node:${VERSION}-buster"
2765
]
2866
}
29-
},
67+
},
3068
"dependencies": {
3169
"image": "node:${VARIANT}",
3270
"imageLink": "https://hub.docker.com/_/node",
33-
"apt": [{
34-
"cgIgnore": false,
35-
"name": "yarn"
36-
}],
71+
"apt": [
72+
{
73+
"cgIgnore": false,
74+
"name": "yarn"
75+
}
76+
],
3777
"git": {
3878
"Oh My Zsh!": "/home/node/.oh-my-zsh",
3979
"nvm": "/usr/local/share/nvm"
@@ -51,4 +91,4 @@
5191
"git": {}
5292
}
5393
}
54-
}
94+
}

0 commit comments

Comments
 (0)